Initialize deviceInfo in constructor of ParselyTracker

[wzieba]

Closes: #57

Description

This PR addresses the issue reported in #57 by initializing deviceInfo synchronously in the constructor of the ParselyTracker, rather than waiting for GetAdKey async task to complete.

It brings back part of the behavior from before #56 (which introduced the discussed bug) but makes it more explicitly, that initial creation of deviceInfo passes null for adKey property.

Reproduction

1. Checkout trunk
2. Apply the PATCH

PATCH

Subject: [PATCH] refactor: move plugins configuration to pluginManagement
---
Index: parsely/src/main/java/com/parsely/parselyandroid/ParselyTracker.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/parsely/src/main/java/com/parsely/parselyandroid/ParselyTracker.java b/parsely/src/main/java/com/parsely/parselyandroid/ParselyTracker.java
--- a/parsely/src/main/java/com/parsely/parselyandroid/ParselyTracker.java	(revision 652ccbec41975239f3981289d94a40335f2495b2)
+++ b/parsely/src/main/java/com/parsely/parselyandroid/ParselyTracker.java	(date 1693839376735)
@@ -738,6 +738,11 @@
         protected String doInBackground(Void... params) {
             AdvertisingIdClient.Info idInfo = null;
             String advertId = null;
+            try {
+                Thread.sleep(10000);
+            } catch (InterruptedException e) {
+                throw new RuntimeException(e);
+            }
             try {
                 idInfo = AdvertisingIdClient.getAdvertisingIdInfo(mContext);
             } catch (GooglePlayServicesRepairableException | IOException | GooglePlayServicesNotAvailableException | IllegalArgumentException e) {

3. Run the example app and within 10 seconds tap on "track url" button.

[ParaskP7]

👋 @wzieba !

I have reviewed and tested this PR as per the reproduction instructions, everything works as expected, I was able to crash the app without this.deviceInfo = collectDeviceInfo(null);, and able to verify that it is now not crashing when this line fix is included, good job, I think we can safely merge this now! 🌟 🌟 🌟

[ParaskP7]

Question (❓): Just to confirm that, why was that deleted? My guess is because it is just being a duplicate of dInfo.put("parsely_site_uuid", uuid);, right?

FYI: Because this change was included as part of this 98c1dd6 refactor commit, which was mainly about removing the adKey field, it kind of made it harder for me to understand. Although you did add this on the description, I just want to be sure of it (🤷 + 😊): It makes codebase easier to understand and eliminates multiple sources for 'parsely_site_uuid'.

[wzieba]

Yes, this code was duplicating dInfo.put("parsely_site_uuid", uuid) from collectDeviceInfo.