Send events automatically on application onStop
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added constraint of `kotlin-stdlib-jdk7` and `kotlin-stdlib-jdk8` ensures lack of "duplicated class" conflicts. This is required due to unification of jdk7 and jdk8 libraries by Kotlin. See details: https://kotlinlang.org/docs/gradle-configure-project.html#other-ways-to-align-versions
The lint bundled with AGP 7.2.2 has a bug which reports false-positive errors: https://issuetracker.google.com/issues/185418482#comment31
wzieba
force-pushed
the
flush_events_on_app_on_stop
branch
from
183ecb2
to
605c535
Compare
To fix: `LintClient has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0` on CI.
|
|
Merged
ParaskP7
reviewed
Oct 12, 2023
There was a problem hiding this comment.
👋 @wzieba !
I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟
I have left one question (❓), a suggestion (💡) and one minor (🔍) comment for you to consider. I am not going to approve this PR atm and until we discuss on that question (❓) of mine, but at the same time, I don't wan't to request changes as I am not sure about it too, thus I'll be just commenting for now.
parsely/src/main/java/com/parsely/parselyandroid/ParselyTracker.java
Outdated
Show resolved
Hide resolved
|
👋 @wzieba ! Took another look at the extra 2 commits added, thanks and everything LGTM, feel free to merge this when you're ready! 🚀 |
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #76
Description
This PR introduces a new behavior of automatically flushing the events queue using
ProcessLifecycleOwner. This API is used in e.g.AppLifecycleIntegration.ktfrom Sentry Android SDK which works similarly to Parse.ly SDK in the sense of observing application lifecycle.At the same time, this PR deprecates manual queue flushing.
How to test
Before
mainPOST Data {"events":logAfter
POST Data {"events":log is logged imidiatelly after app is moved to the backgroundDependency change report
\--- androidx.appcompat:appcompat:1.4.2 +--- androidx.core:core:1.7.0 - | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.0 - | | +--- androidx.arch.core:core-runtime:2.1.0 - | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 - | | | \--- androidx.arch.core:core-common:2.1.0 - | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0 - | | +--- androidx.lifecycle:lifecycle-common:2.4.0 - | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0 - | | +--- androidx.arch.core:core-common:2.1.0 (*) - | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.6.2 + | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | +--- androidx.arch.core:core-common:2.2.0 + | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | +--- androidx.arch.core:core-runtime:2.2.0 + | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | | \--- androidx.arch.core:core-common:2.2.0 (*) + | | +--- androidx.lifecycle:lifecycle-common:2.6.2 + | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 + | | | | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.10 + | | | | \--- org.jetbrains:annotations:13.0 + | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 + | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 + | | | | | \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 + | | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4 + | | | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 (c) + | | | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4 (c) + | | | | | | \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4 (c) + | | | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.8.10 + | | | | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) + | | | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.10 + | | | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) + | | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21 -> 1.8.10 + | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.4 (*) + | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.8.10 (*) + | | | +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c) + | | | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c) + | | +--- androidx.profileinstaller:profileinstaller:1.3.0 + | | | +--- androidx.annotation:annotation:1.2.0 -> 1.3.0 + | | | +--- androidx.concurrent:concurrent-futures:1.1.0 + | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | | | \--- com.google.guava:listenablefuture:1.0 + | | | +--- androidx.startup:startup-runtime:1.1.1 + | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | | | \--- androidx.tracing:tracing:1.0.0 + | | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | | \--- com.google.guava:listenablefuture:1.0 + | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) + | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c) + | | \--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c) - | \--- androidx.concurrent:concurrent-futures:1.0.0 - | +--- com.google.guava:listenablefuture:1.0 - | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | \--- androidx.concurrent:concurrent-futures:1.0.0 -> 1.1.0 (*) +--- androidx.activity:activity:1.2.4 - | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.0 (*) + | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.6.2 (*) - | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 - | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.6.2 + | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) + | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c) + | | \--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c) - | +--- androidx.savedstate:savedstate:1.1.0 - | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 - | | +--- androidx.arch.core:core-common:2.0.1 -> 2.1.0 (*) - | | \--- androidx.lifecycle:lifecycle-common:2.0.0 -> 2.4.0 (*) + | +--- androidx.savedstate:savedstate:1.1.0 -> 1.2.1 + | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | +--- androidx.arch.core:core-common:2.1.0 -> 2.2.0 (*) + | | +--- androidx.lifecycle:lifecycle-common:2.6.1 -> 2.6.2 (*) + | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) - | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 - | | +--- androidx.annotation:annotation:1.0.0 -> 1.3.0 - | | +--- androidx.savedstate:savedstate:1.1.0 (*) - | | +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1 - | | | +--- androidx.arch.core:core-common:2.1.0 (*) - | | | +--- androidx.arch.core:core-runtime:2.1.0 (*) - | | | \--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.0 (*) - | | \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*) + | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.6.2 + | | +--- androidx.annotation:annotation:1.0.0 -> 1.3.0 + | | +--- androidx.core:core-ktx:1.2.0 + | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.41 -> 1.8.10 (*) + | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | | | \--- androidx.core:core:1.2.0 -> 1.7.0 (*) + | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 + | | | +--- androidx.arch.core:core-common:2.1.0 -> 2.2.0 (*) + | | | +--- androidx.arch.core:core-runtime:2.1.0 -> 2.2.0 (*) + | | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (*) + | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) + | | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c) + | | | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (*) + | | +--- androidx.savedstate:savedstate:1.2.1 (*) + | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) + | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 (*) + | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c) + | | \--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c) - | \--- androidx.tracing:tracing:1.0.0 - | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0 + | \--- androidx.tracing:tracing:1.0.0 (*) +--- androidx.fragment:fragment:1.3.6 | +--- androidx.loader:loader:1.0.0 - | | +--- androidx.lifecycle:lifecycle-livedata:2.0.0 - | | | +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*) - | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.0.0 -> 2.3.1 (*) - | | | \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*) + | | +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2 + | | | +--- androidx.arch.core:core-common:2.1.0 -> 2.2.0 (*) + | | | +--- androidx.arch.core:core-runtime:2.1.0 -> 2.2.0 (*) + | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (*) + | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) + | | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-process:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c) + | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c) + | | | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c) - | | \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.3.1 (*) + | | \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.6.2 (*) - | +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1 (*) + | +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1 -> 2.6.2 (*) - | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*) + | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.6.2 (*) - | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*) + | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.6.2 (*) - | \--- androidx.savedstate:savedstate:1.1.0 (*) + | \--- androidx.savedstate:savedstate:1.1.0 -> 1.2.1 (*) - +--- androidx.savedstate:savedstate:1.1.0 (*) + +--- androidx.savedstate:savedstate:1.1.0 -> 1.2.1 (*) +--- androidx.emoji2:emoji2:1.0.0 - | +--- androidx.lifecycle:lifecycle-process:2.4.0 - | | +--- androidx.lifecycle:lifecycle-runtime:2.4.0 (*) - | | \--- androidx.startup:startup-runtime:1.0.0 - | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0 - | | \--- androidx.tracing:tracing:1.0.0 (*) + | +--- androidx.lifecycle:lifecycle-process:2.4.0 -> 2.6.2 + | | +--- androidx.annotation:annotation:1.2.0 -> 1.3.0 + | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (*) + | | +--- androidx.startup:startup-runtime:1.1.1 (*) + | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.10 (*) + | | +--- androidx.lifecycle:lifecycle-runtime:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-livedata-core:2.6.2 (c) + | | +--- androidx.lifecycle:lifecycle-common:2.6.2 (c) + | | \--- androidx.lifecycle:lifecycle-livedata:2.6.2 (c) - | \--- androidx.startup:startup-runtime:1.0.0 (*) + | \--- androidx.startup:startup-runtime:1.0.0 -> 1.1.1 (*) - +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.0 (*) + +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.6.2 (*) - \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*) + \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.6.2 (*) ++--- androidx.lifecycle:lifecycle-process:2.6.2 (*) ++--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.10 (c) +\--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.10 (c)