Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov token #80

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Add Codecov token #80

merged 1 commit into from
Oct 18, 2023

Conversation

wzieba
Copy link
Collaborator

@wzieba wzieba commented Oct 17, 2023

Internal discussion about token generation: p1697550961218509-slack-C05C1C14UKF

Although open source projects don't require upload with token, CodeCov
default token meets limits sometimes, resulting in failed uploads. See
more details here:
codecov/codecov-action#557 (comment).

The solution is to use our own Codecov token.
@wzieba wzieba requested a review from ParaskP7 October 17, 2023 14:41
@ParaskP7 ParaskP7 self-assigned this Oct 18, 2023
Copy link
Collaborator

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @wzieba and thanks for adding this token! 🌟

Question (❓): I am seeing that this CODECOV_TOKEN is being defined within our secrets, under the woocommerce-android CI specific secrets space. Maybe it is better to either create a new token and put it under a new parsely-android CI secrets space, or move this same CODECOV_TOKEN secret into its own common android space. Wdyt? 🤔

FYI: I am hoping to avoid using a woocommerce-android CI specific secrets on another project/repo as in due time this information will get lost and misconfigurations might start happening, I am thinking of engineers removing this CI secrets, them thinking it only affects the woocommerce-android project/repo, not knowing that this is also affecting other projects/repos, thus causing a regression on them. 🤷

@wzieba
Copy link
Collaborator Author

wzieba commented Oct 18, 2023

I am seeing that this CODECOV_TOKEN is being defined within our secrets, under the woocommerce-android CI specific secrets space.

Sorry, I'm not sure if I follow. The CODECOV_TOKEN is defined in GitHub settings of the parsely-android repository. It has no connection with woocommerce-android repository whatsoever.

@ParaskP7
Copy link
Collaborator

Sorry, I'm not sure if I follow. The CODECOV_TOKEN is defined in GitHub settings of the parsely-android repository. It has no connection with woocommerce-android repository whatsoever.

Ah sorry @wzieba , for some reason I thought that this CODECOV_TOKEN was defined in our own secrets, approving... 😅

Just to make sure of it, just for my information, we are using a separate CODECOV_TOKEN for these 2 projects, woocommerce-android and parsely-android, right? 🤔

@wzieba
Copy link
Collaborator Author

wzieba commented Oct 18, 2023

Ah I see!

Just to make sure of it, just for my information, we are using a separate CODECOV_TOKEN for these 2 projects, woocommerce-android and parsely-android, right? 🤔

Yes - those are two separate, completely unrelated tokens 👍 Thanks for the review!

@wzieba wzieba merged commit e33285b into main Oct 18, 2023
3 checks passed
@wzieba wzieba deleted the fix_codecov_upload branch October 18, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants