Merge pull request #804 from Parsely/bugfix/missing_replica_update

only add brokers to replicas set that the cluster is aware of
Parsely · May 16, 2018 · 97c764a · 97c764a
2 parents d1e3ee4 + ea094f3
commit 97c764a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pykafka/topic.py b/pykafka/topic.py
@@ -229,7 +229,10 @@ def update(self, metadata):
                 self._partitions[meta.id] = Partition(
                     self, meta.id,
                     brokers[meta.leader],
-                    [brokers[b] for b in meta.replicas],
+                    # only add replicas that the cluster is aware of to avoid
+                    # KeyErrors here. inconsistencies will be automatically
+                    # resolved when `Cluster.update` is called.
+                    [brokers[b] for b in meta.replicas if b in brokers],
                     [brokers[b] for b in meta.isr],
                 )
             else: