Skip to content
This repository has been archived by the owner on Mar 24, 2021. It is now read-only.

Commit

Permalink
allow version to be imported separately from the rest of the project
Browse files Browse the repository at this point in the history
  • Loading branch information
@emmettbutler
emmettbutler committed Apr 23, 2015
1 parent 9145ec8 commit d2e534c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion pykafka/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
limitations under the License.
"""

__version__ = '1.0.0'
from version import version
__version__ = version

from client import KafkaClient
from balancedconsumer import BalancedConsumer
4 changes: 2 additions & 2 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

from setuptools import setup, find_packages

from pykafka import __version__
from version import version

install_requires = [
'kazoo'
Expand All @@ -39,7 +39,7 @@

setup(
name='pykafka',
version=__version__,
version=version,
author='Keith Bourgoin',
author_email='pykafka-user@googlegroups.com',
url='https://github.com/Parsely/pykafka',
Expand Down
1 change: 1 addition & 0 deletions version.py
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
version = '1.0.0'

7 comments on commit d2e534c

@hellais
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the package when installed with pip.

@kbourgoin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,

We've got a Pull Request open to fix this (#159). We'll be taking a look and merging it later this week.

Keith.

@hellais
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok great. Also, why is this package not on pypi?

@kbourgoin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still under development. We plan on doing a full release within a week or two. As such, please use at your own risk. Most of it is stable, but we can't promise there aren't bugs that are still hidden.

@hellais
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok I see. Then how does your library compare to kafka-python, why did you develop your own instead of joining that effort?

@kbourgoin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to be a library called samsa, for the 0.7.x branch of Kafka and had a full balanced consumer implementation. We started to upgrade to 0.8.x before finding kafka-python and decided to keep with that since the maintainer expressed that he didn't want a balanced consumer implementation in that library. We need a balancing consumer for our internal uses, so not having that wasn't an option. He's also since indicated that he's not interested in maintaining the project, so we decided to finish our own upgrade and rename it to pykafka.

At some point, we'll run some benchmarks between the two libraries, but that'll be after we do a full release. I'm pretty confident our implementation will be more performant, and we're also trying to integrate a wrapper for the C library librdkafka for even greater performance. Those speedups would be optional, obviously, as the pure-python implementation will be easier to install for some people.

@hellais
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbourgoin thank you very much for the thorough comparison. This helps me a lot.

Please sign in to comment.