This repository has been archived by the owner on Mar 24, 2021. It is now read-only.
Concurrent fetch #31
Merged
Concurrent fetch #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes worker threads and instead laucnhes a new thread per fetch request.
This was referenced Aug 4, 2012
Closed
ghost
assigned 
…t_fetch Conflicts: samsa/consumer/partitions.py
|
|
||
| msg = self.queue.get(True, timeout) | ||
| self._offset = msg.next_offset | ||
| return msg.payload |
There was a problem hiding this comment.
should either be msg or message throughout
Conflicts: samsa/config.py
Conflicts: samsa/config.py
There's now a handler class which will abstract threading vs gevent. The RequestHandler now accepts that class to figure out how to spawn workers. also add client attribute to ManagedBroker
| @@ -325,6 +223,7 @@ def connect(self): | |||
| """ | |||
| self._socket = socket.create_connection((self.host, self.port), | |||
| timeout=self.timeout) | |||
| self._socket.settimeout(self.timeout) | |||
There was a problem hiding this comment.
isn't this the same as the timeout kwarg to create_connection?
|
looks pretty good overall, thanks for all your work on this i don't think there's anything really blocking it from being merged into master at this point but there's some general cleanup we could do — i'm +1 if you want to merge now, or you can clean up from the notes above and we can merge in after — your call |
|
Thanks @tkaemming for your excellent notes. I think I've covered them in 7127300 and e0ec6ea but I'm rushing so will wait to merge them until I get in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all tests passing.
Please do take the time to do a thorough code review. We can do it together if you prefer. It also might be a good idea to get a third set of eyes on the threading code. Hopefully someone with more experience with them than I do.