-
Notifications
You must be signed in to change notification settings - Fork 191
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove return bool from Channel.close() (#3403)
Theres was no defined meaning to the return bool either in the code or in the human text: - no code calls close to give an example of interpretation - it's not success/fail because local channel returns False to indicate that it didn't need to do anything, not that there was a failure. Other .close() style methods return None and raise an exception if there is a problem. This PR pushes Channel.close() in this direction. A separate PR will actually invoke this .close() method.
- Loading branch information
1 parent
e55ed98
commit 441a369
Showing
4 changed files
with
9 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters