Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsl[monitoring] pins sqlalchemy to <1.4 #2296

Closed
jacopo-exact opened this issue Jun 22, 2022 · 1 comment · Fixed by #2297
Closed

parsl[monitoring] pins sqlalchemy to <1.4 #2296

jacopo-exact opened this issue Jun 22, 2022 · 1 comment · Fixed by #2297
Labels

Comments

@jacopo-exact
Copy link
Contributor

Describe the bug
Parsl[monitoring] currently requires sqlalchemy <1.4, making it difficult to integrate with other packages that depend on newer versions.

This issue is related to #1994, solved in fd8072f, where it was found that sqlalchemy-utils 0.36.8 was incompatible with squalchemy 1.4.0.

However the newest sqlalchemy-utils 0.38.2 does not seem to break with sqlalchemy 1.4.37. Indeed,

pytest parsl/tests/test_monitoring/ --config local

succeeds with 4/4 passed.

To Reproduce
n/a

Expected behavior
Parsl[monitoring] should depend on the newest version that does not explicitly break functionality

Environment

  • OS: Linux 5.17.9-arch1-1 #1 SMP PREEMPT Wed, 18 May 2022 17:30:11 +0000 x86_64 GNU/Linux
  • Python 3.10.4
  • Parsl 1.2.0

Distributed Environment

  • Where are you running the Parsl script from?
    Currently testing on a local machine. Will deploy on a cluster as part of a larger service whose web interface could benefit from newer sqlalchemy

  • Where do you need the workers to run ?
    Workers will run mostly on a slurm cluster, although the issue is relative to the master only, the only one to have the monitoring

@benclifford
Copy link
Collaborator

Fixed by 2297

benclifford pushed a commit that referenced this issue Jun 28, 2022
As newest versions of sqlalchemy appear to be compatible with sqlalchemy-utils and with the monitoring subsystem, this PR relaxes the constraint on sqlalchemy.

Fixes #2296
tcompa pushed a commit to fractal-analytics-platform/parsl that referenced this issue Jul 5, 2022
As newest versions of sqlalchemy appear to be compatible with sqlalchemy-utils and with the monitoring subsystem, this PR relaxes the constraint on sqlalchemy.

Fixes Parsl#2296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants