Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify AppBadFormatting error #433

Closed
annawoodard opened this issue Aug 3, 2018 · 0 comments
Closed

Clarify AppBadFormatting error #433

annawoodard opened this issue Aug 3, 2018 · 0 comments
Assignees
Milestone

Comments

@annawoodard
Copy link
Collaborator

annawoodard commented Aug 3, 2018

As reported by @madduri.

The error message raised on badly formatted bash apps is not clear. This is slightly better for threads than IPP, but both are not as helpful as they should be. We need to make sure the error message the user sees is actually formatted with the info we want to provide. Also, we should add more info: all of the args, kwargs, template, etc.

With IPP:

Traceback (most recent call last):
  File "/Users/awoodard/ci/parsl/parsl/dataflow/dflow.py", line 187, in handle_update
    res = future.result()
  File "/Users/awoodard/software/anaconda3/envs/parsl_py36/lib/python3.6/concurrent/futures/_base.py", line 398, in result
    return self.__get_result()
  File "/Users/awoodard/software/anaconda3/envs/parsl_py36/lib/python3.6/concurrent/futures/_base.py", line 357, in __get_result
    raise self._exception
  File "/Users/awoodard/software/anaconda3/envs/parsl_py36/lib/python3.6/site-packages/ipyparallel/client/asyncresult.py", line 224, in _resolve_result
    raise r
ipyparallel.error.RemoteError: AppBadFormatting()

With threads:

Traceback (most recent call last):
  File "/Users/awoodard/ci/parsl/parsl/app/bash.py", line 34, in remote_side_bash_executor
    executable = partial_cmdline.format(*args, **kwargs)
IndexError: tuple index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "test_bash_apps/test_error_codes.py", line 184, in <module>
    test_bash_formatting()
  File "test_bash_apps/test_error_codes.py", line 76, in test_bash_formatting
    f.result()
  File "/Users/awoodard/ci/parsl/parsl/dataflow/futures.py", line 117, in result
    res = self.parent.result(timeout=timeout)
  File "/Users/awoodard/software/anaconda3/envs/parsl_py36/lib/python3.6/concurrent/futures/_base.py", line 405, in result
    return self.__get_result()
  File "/Users/awoodard/software/anaconda3/envs/parsl_py36/lib/python3.6/concurrent/futures/_base.py", line 357, in __get_result
    raise self._exception
  File "/Users/awoodard/ci/parsl/parsl/dataflow/dflow.py", line 187, in handle_update
    res = future.result()
  File "/Users/awoodard/software/anaconda3/envs/parsl_py36/lib/python3.6/concurrent/futures/_base.py", line 398, in result
    return self.__get_result()
  File "/Users/awoodard/software/anaconda3/envs/parsl_py36/lib/python3.6/concurrent/futures/_base.py", line 357, in __get_result
    raise self._exception
  File "/Users/awoodard/software/anaconda3/envs/parsl_py36/lib/python3.6/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/Users/awoodard/ci/parsl/parsl/app/bash.py", line 43, in remote_side_bash_executor
    raise pe.AppBadFormatting("[{}] App formatting failed during cmd_line resolution: {}".format(func_name, e), None)
parsl.app.errors.AppBadFormatting
@annawoodard annawoodard self-assigned this Aug 3, 2018
@annawoodard annawoodard added this to the Parsl-0.7.0 milestone Aug 3, 2018
annawoodard added a commit that referenced this issue Aug 3, 2018
The reason for the AppBadFormatting error was not actually being
set. Fixes #433.
annawoodard added a commit that referenced this issue Aug 3, 2018
The reason for the AppBadFormatting error was not actually being
set. Fixes #433.
annawoodard added a commit that referenced this issue Aug 3, 2018
The reason for the AppBadFormatting error was not actually being
set. Fixes #433.
j-woz pushed a commit to j-woz/parsl that referenced this issue Oct 15, 2018
j-woz referenced this issue in j-woz/parsl Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant