Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps without a specified DFK should use the global DFK in scope at call time, not at other times. #697

Closed
benclifford opened this issue Dec 11, 2018 · 3 comments
Assignees
Milestone

Comments

@benclifford
Copy link
Collaborator

benclifford commented Dec 11, 2018

Often, apps are created with no specified DFK, and in that case they use a global dfk.

The global DFK which is in focus (i.e. stored in DataFlowKernelLoader._dfk) may change over time; for example, in pytest, and in interactive notebook sessions as people experiment.

The parsl code is a little vague on which global DFK will be used: the bash and python app decorators cache the global DFK inside the decorated app at first invocation, and use that forevermore - even if that DFK has been shutdown (a case which doesn't have clean error handling at the moment)

I posit that a user specifying no DFK will usually want to use the global DFK that is in focus at the time that they invoke the app, not at the time they first invoked the app; and that if they make separate invocations at different times with different DFKs in focus, then those different invocations should use those different DFKs.

If so, app decorators should not cache DFKs between calls.

@benclifford benclifford added this to the Parsl-0.8.0 milestone Dec 11, 2018
@annawoodard
Copy link
Collaborator

Agreed!

@benclifford benclifford self-assigned this Dec 15, 2018
@benclifford
Copy link
Collaborator Author

Fixed by #712

@benclifford
Copy link
Collaborator Author

duplicate of #626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants