Move monitoring wrapper code into its own module #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid capturing so much in the closure of the monitoring wrapper, which prior to this patch, captured a lot of surprising stuff. This reduces serialisation load (time and space). With parsl/tests/test_bash/test_basic.py, using Work Queue and monitoring, the five serialized function sizes are: before this commit: 8400 bytes after this commit: 7252 bytes saving 1148 bytes per function invocation.
benclifford
added a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid capturing so much in the closure of the monitoring wrapper, which prior to this patch, captured a lot of surprising stuff.
This reduces serialisation load (time and space).
With parsl/tests/test_bash/test_basic.py, using Work Queue and monitoring, the five serialized function sizes are:
before this commit: 8400 bytes
after this commit: 7252 bytes
saving 1148 bytes per function invocation.
Type of change