Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or reduce some test sleeps #2771

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Remove or reduce some test sleeps #2771

merged 2 commits into from
Jul 5, 2023

Conversation

khk-globus
Copy link
Collaborator

  • Make some test code more Pythonic (e.g., generators, list comprehension)
  • Remove a number of unnecessary sleep calls (or vastly reduce)
  • Teach some tests to assert
  • Remove more print()s

Type of change

  • Code maintenance/cleanup

@khk-globus khk-globus force-pushed the test_remove_reduce_sleep branch 2 times, most recently from d1d08c3 to 5496223 Compare June 28, 2023 18:21
benclifford
benclifford requested changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@benclifford benclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my main concern is the introduction of randomization in test_fail

@khk-globus
Copy link
Collaborator Author

my main concern is the introduction of randomization in test_fail

The main change is in removing the .sleep() call that was randomizing when calls would fail. But these tests weren't verifying anything to do with time — like that the app fails as soon as possible. That might be an additional test, but I'm trying for these set of changes to strictly remove the .sleep() calls where I can.

@khk-globus
Remove or reduce some test sleeps
1414f89 
- Make some test code more pythonic (e.g., generators, list comprehension)
- Remove a number of unnecessary sleep calls (or vastly reduce wait time)
- Teach some tests to `assert`
- Remove more `print()`s
@benclifford benclifford merged commit 6b81796 into master Jul 5, 2023
4 checks passed
@benclifford benclifford deleted the test_remove_reduce_sleep branch July 5, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benclifford benclifford benclifford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khk-globus @benclifford