Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoStatusHandlingExecutor #2855

Merged
merged 2 commits into from Aug 7, 2023
Merged

Remove NoStatusHandlingExecutor #2855

merged 2 commits into from Aug 7, 2023

Conversation

benclifford
Copy link
Collaborator

Executors which want to use status handling should subclass the BlockProviderExecutor, formerly (PR #2071) known as the StatusHanldingExecutor.

Code which performs status handling should only operate on BlockProviderExecutor instances - the status handling code shouldn't do anything to other ParslExecutor instances.

Type of change

  • Code maintentance/cleanup

Executors which want to use status handling should subclass the
BlockProviderExecutor, formerly (PR #2071) known as the
StatusHanldingExecutor.

Code which performs status handling should only operate on
BlockProviderExecutor instances - the status handling code shouldn't
do anything to other ParslExecutor instances.
@benclifford benclifford marked this pull request as ready for review August 7, 2023 17:31
Copy link
Member

@yadudoc yadudoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yadudoc yadudoc merged commit 4b50ab0 into master Aug 7, 2023
4 checks passed
@yadudoc yadudoc deleted the benc-no-nostatushandling branch August 7, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants