Use a defaultdict for BlockInfo in htex scale-in #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to accomodate upcoming expansion of the block_info dictionary to include data from an additional source (the list of blocks known to the scaling code) This change arises from a review of PR #3232, an earlier prototype of that expansion work. Behaviourally, this shouldn't change anything: it changes invalid block accesses from key errors into blocks that are infinitely idle and completely unloaded. However there are no indexes into block_info except in code that is adding block information, so this situation should not arise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to accomodate upcoming expansion of the block_info dictionary to include data from an additional source (the list of blocks known to the scaling code)
This change arises from a review of PR #3232, an earlier prototype of that expansion work.
Changed Behaviour
Behaviourally, this shouldn't change anything: it changes invalid block accesses from key errors into blocks that are infinitely idle and completely unloaded. However there are no indexes into block_info except in code that is adding block information, so this situation should not arise.
Type of change