Rename PolledExecutorFacade methods that overlap BlockProviderExecutor #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for moving all the PolledExecutorFacade code into BlockProviderExecutor, in an upcoming PR. There should now be no intersection in the attributes or methods of PolledExecutorFacade and BlockProviderExecutor, in the methods that will move. __init__ is an exception because it will merge with the __init__ of BlockProviderException. The renamed methods are slightly awkwardly named because there isn't a short adjective that I have found that adequately describes the difference between BlockProviderExecutor and PolledExecutorFacade behaviours. Future untangling work in this area will necessarily involve quite a lot of rearranging and picking appropriate names for whatever remains is part of that future work - so no bikeshedding over adjectives. This PR should only rename methods. It should not change any behaviour.
khk-globus
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for moving all the
PolledExecutorFacadecode intoBlockProviderExecutor, in an upcoming PR.There should now be no intersection in the attributes or methods of
PolledExecutorFacadeandBlockProviderExecutor, in the methods that will move.__init__is an exception because it will merge with the__init__ofBlockProviderException.The renamed methods are slightly awkwardly named because there isn't a short adjective that I have found that adequately describes the difference between
BlockProviderExecutorandPolledExecutorFacadebehaviours.Future untangling work in this area will necessarily involve quite a lot of rearranging and picking appropriate names for whatever remains is part of that future work - so no bikeshedding over adjectives.
This PR should only rename methods and attributes. It should not change any behaviour.
Type of change