Fixed Kubernetes worker container launch command to remove trailing semicolon. #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tried it out, but that ; is maybe unnecessary and could be removed? At first glance it looks like noise to me. |
shishichen
force-pushed
the
fix-k8s-launch-cmd
branch
from
bfc0768
to
f806e25
Compare
shishichen
force-pushed
the
fix-k8s-launch-cmd
branch
from
f806e25
to
8b39024
Compare
shishichen
changed the title
|
Yeah, that works too - updated. |
benclifford
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The launch command is formatted with a newline at the end so when the trailing semicolon is added here, it causes the semicolon to be run as a separate bash command by the worker. A single semicolon is a syntax error in bash and produces an error in container logs when the container tries to run it. Removing it is safe since it's at the end of the command and nothing is concatenated after it.
Changed Behaviour
Remove an error in the Kubernetes worker container logs.
Fixes
Fixes # n/a - minor issue
Type of change