Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintuitive behaviour of sidebar items #458

Closed
NomAnor opened this issue Dec 16, 2023 · 2 comments
Closed

Unintuitive behaviour of sidebar items #458

NomAnor opened this issue Dec 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@NomAnor
Copy link

NomAnor commented Dec 16, 2023

Describe the bug
When you click on a sidebar item, it gets selected (blue background) and the corresponding page is loaded.
When you click again on the selected item, it gets deselected and nothing happens. I find this a weird behaviour for a navigation sidebar. I would expect that every click causes the correspondig page to load and the already selected page to just reload.

Also the selection seems to be per group. I can have a blue background on a category item and a tool item whereas only the current page should be highligted in the navigation.

Background
When I look at a part info page and I want to go back to the category, I often click on the category again, but nothing happens because it gets deselected.

Server Side

  • Part-DB Version: 1.10.1 (docker)
  • PHP Version: 8.1.26 (SAPI: fpm-fcgi)
  • Database Server: sqlite (3.34.1)

Desktop (please complete the following information):

  • OS: Arch Linux
  • Browser: Firefox
  • Version: 120.0
@NomAnor NomAnor added the bug Something isn't working label Dec 16, 2023
@Tolomaj
Copy link

Tolomaj commented Jan 5, 2024

I got same bug happening

Server Side

  • Part-DB Version: 1.10.1
  • PHP Version: PHP 8.1.27

Desktop (please complete the following information):

  • OS: Windows 12
  • Browser: Google Chrome
  • Version: 120.0.6099.131

jbtronics added a commit that referenced this issue Jan 27, 2024
jbtronics added a commit that referenced this issue Jan 27, 2024
…nstead of just unselecting it

This fixes the somehow unintuitive behavior described in issue #458
@jbtronics
Copy link
Member

This should be fixed now with the latest changes. The page gets directly called, if you click on an already selected node.

Additionally, a node now should get automatically unselected, if you navigate away from the page which the node refers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants