Fix RegEx to handle negative values and Ohms without prefix #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frank-f
changed the title
|
I just noticed, that a parameter value of 120Ω was also not correctly parsed. |
frank-f
changed the title
|
I'll add more tweaks while polishing my database, but won't explain each one. Just ask here, if you have questions. |
…e to pick up for example "ppm/°C"
|
Looks great. Thank you. |
jbtronics
added a commit
that referenced
this pull request
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor tweak for #526, specifically for #526 (comment)
I noticed, that (LCSC) attributes of ranges with negative values were still saved as text. That was due to the minus character, that was missing from the regular expression in splitIntoValueAndUnit().