Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup basic configuration #2

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Setup basic configuration #2

merged 2 commits into from
Dec 8, 2021

Conversation

slfuchs
Copy link
Member

@slfuchs slfuchs commented Dec 5, 2021

Setup the basic configuration of PartExa making use of provided deal.II functionality. This includes the configuration of clang-format, cmake, and the testing framework.

@slfuchs slfuchs force-pushed the setup-basic-config-and-testing branch from 9b48bbd to 097a184 Compare December 6, 2021 08:36
@slfuchs
Copy link
Member Author

slfuchs commented Dec 6, 2021

@ppraegla, @nfehn, @peterrum: This pull request adds a very basic configuration following the documentation of deal.II. This can be seen as a starting point for further development. In a next step, I will work on a brief documentation in the wiki herein.

slfuchs
slfuchs commented Dec 6, 2021
View reviewed changes
.clang-format Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
tests/base/print_partexa_header.output Outdated Show resolved Hide resolved
peterrum
peterrum reviewed Dec 6, 2021
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
tests/base/CMakeLists.txt Show resolved Hide resolved
nfehn
nfehn reviewed Dec 6, 2021
View reviewed changes
include/base/print_infos.h Outdated Show resolved Hide resolved
@slfuchs slfuchs force-pushed the setup-basic-config-and-testing branch 2 times, most recently from e193051 to c7741ec Compare December 7, 2021 22:27
@slfuchs
Copy link
Member Author

slfuchs commented Dec 7, 2021

I included all suggestions made so far and pushed the changes. Currently I am waiting for the outcome of dealii/dealii/pull/13033 as it would allow us to remove the copy of the tests.h file.

@peterrum
Copy link
Contributor

peterrum commented Dec 7, 2021

I included all suggestions made so far and pushed the changes. Currently I am waiting for the outcome of dealii/dealii/pull/13033 as it would allow us to remove the copy of the tests.h file.

I wouldn't wait.

@slfuchs slfuchs force-pushed the setup-basic-config-and-testing branch from c7741ec to b62ed0e Compare December 8, 2021 09:48
@slfuchs
Copy link
Member Author

slfuchs commented Dec 8, 2021 •
edited

@peterrum I added now the reduced version of the tests.h file. In addition to what you prepared I included the header <fstream> and added the definition void cat_file(const char *filename).

peterrum
peterrum approved these changes Dec 8, 2021
View reviewed changes
tests/tests.h Show resolved Hide resolved
@slfuchs
Add clang-format configuration based on deal.II
b66cc4e
@slfuchs
Setup basic cmake and testing configuration
03b8fe4 
Setup a basic cmake configuration for the library PartExa
(including deal.II) and a testing configuration.

Introduce a PartExa header that is printed during configuration and
printed to the output stream by a function. Add test for this function.
@slfuchs slfuchs force-pushed the setup-basic-config-and-testing branch from b62ed0e to 03b8fe4 Compare December 8, 2021 11:31
@slfuchs
Copy link
Member Author

slfuchs commented Dec 8, 2021

Thanks for the feedback to all. I included everything as discussed above and merge this pull request now.

@slfuchs slfuchs merged commit e95d7f4 into PartExa:master Dec 8, 2021
@slfuchs slfuchs deleted the setup-basic-config-and-testing branch December 8, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterrum peterrum peterrum approved these changes

@nfehn nfehn nfehn left review comments

@ppraegla ppraegla ppraegla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slfuchs @peterrum @nfehn @ppraegla