Fix #20, search by file name #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @TheAwiteb , This returns only file name... We need to return the Path of the given file 😄 |
|
Yes, i see, how i forget this 😅 |
|
Haha, No worries |
ParthJadhav
reviewed
Nov 13, 2022
Both |
|
Oh okay, Let me test this once and then we can merge this |
|
Do you have any ideas about this one ? I tried using .sort_by_file_name() in the walkdir builder but it doesn't work on parallel walker. And if we were to walk on single thread then it would turn out to be slow... |
|
Awesome @TheAwiteb , Works as expected !! Merging this |
I'm not really good with sorting, sorry |
ParthJadhav
approved these changes
Nov 13, 2022
No problem, I'll investigate further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20