Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of #![warn(clippy::nursery, clippy::pedantic)]. #27

Merged
merged 3 commits into from Jan 6, 2023

Conversation

Xithrius
Copy link
Contributor

@Xithrius Xithrius commented Jan 4, 2023

Helping out with linting, asked here to do this.

I cannot build this on linux, since it relies on the OS being macos. Any testing to see if this actually fully works can only be on that system.

@Xithrius
Copy link
Contributor Author

Xithrius commented Jan 4, 2023

An example of something that I cannot test is ActivationPolicy, since it's only available on macos.

@Xithrius Xithrius marked this pull request as ready for review January 4, 2023 20:39
@ParthJadhav
Copy link
Owner

Okay @Xithrius , give me a while to test & review it. Thanks a lot for the contribution 🚀

Copy link
Owner

@ParthJadhav ParthJadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change about re-adding that line and then we can merge it 🙌

@ParthJadhav ParthJadhav merged commit 5041e3d into ParthJadhav:master Jan 6, 2023
@ParthJadhav ParthJadhav linked an issue Jan 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Linting
2 participants