Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling Blob Public Access breaks the transport #631

Closed
3 tasks done
SeanFeldman opened this issue May 28, 2021 · 1 comment · Fixed by #643
Closed
3 tasks done

Disabling Blob Public Access breaks the transport #631

SeanFeldman opened this issue May 28, 2021 · 1 comment · Fixed by #643
Labels
Bug

Comments

@SeanFeldman
Copy link
Contributor

SeanFeldman commented May 28, 2021 •
edited

Symptoms

When Blob Public Access is disabled for Storage containers, delayed delivery is failing to create containers required for keeping lease locks.

Who's affected

Anyone using Azure Storage Queues transport with Blob Public Access disabled.

Root cause

The transport passes an incorrect flag to the Storage API when a container needs to be conditionally created, PublicAccessType.BlobContainer or BlobContainerPublicAccessType.Container depending on the Storage SDK version.

Potential fix

Replacing the flag passed in with a stricter value, BlobContainerPublicAccessType.Off or PublicAccessType.None depending on the Storage SDK version.

Additional information

Originally raised on the public forum.

Affected versions

  • NServiceBus.Transport.AzureStorageQueues 9.0, 10.0
  • NServiceBus.Azure.Transports.WindowsAzureStorageQueues 8.2, 7.5 (extended support)

Backported to
SeanFeldman added a commit that referenced this issue Jun 14, 2021
@SeanFeldman
Fixes #631
a4fde74
@SeanFeldman SeanFeldman mentioned this issue Jun 14, 2021
Merged
SeanFeldman added a commit that referenced this issue Jun 15, 2021
@SeanFeldman
Fixes #631
659c51c
@SeanFeldman SeanFeldman mentioned this issue Jun 15, 2021
Merged
SeanFeldman added a commit that referenced this issue Jun 15, 2021
@SeanFeldman
Fixes #631
9234116
This was referenced Jun 15, 2021
Merged
Merged
@SeanFeldman
Copy link
Contributor Author

Patches released: announcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create delayed delivery locks container w/o public access Particular/NServiceBus.AzureStorageQueues
1 participant
@SeanFeldman