Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Newtonsoft.Json 11 #258

Closed
SimonCropp opened this issue Feb 19, 2018 · 20 comments
Closed

Support Newtonsoft.Json 11 #258

SimonCropp opened this issue Feb 19, 2018 · 20 comments
Assignees
Labels
Milestone

Comments

@SimonCropp
Copy link
Contributor

No description provided.

@SzymonPobiega
Copy link
Member

@SimonCropp we're looking into that but we are not yet sure how to proceed with regards to versioning.

@SimonCropp
Copy link
Contributor Author

I think release a new stable minor and a new rc

@SzymonPobiega
Copy link
Member

@SimonCropp that sounds good. We were debating how to handle RC since the new RC that depends on V11 would not be a proper drop-in replacement. We are considering releasing a new RC that targets Netwonsoft [10,12) which should do the trick as from our perspective there are no breaking changes in 11.

@SzymonPobiega SzymonPobiega self-assigned this Feb 26, 2018
@SimonCropp
Copy link
Contributor Author

@jukkahyv
Copy link

Hi, this is quite important for us too, because Newtonsoft.Json 11 is creeping through other nuget packages.

@SimonCropp
Copy link
Contributor Author

bump

@SzymonPobiega
Copy link
Member

@SimonCropp we're working on this

@EvgenyChepurnykh
Copy link

Guys, I think it's a big trouble. We use Newtonsoft.Json v11. Sql.Persistance is uncompatible but moreover NServiceBus.Newtonsoft.Json require version 11 and above.
We have really bad situation:
NServiceBus.Persistance.Sql requires Newtonsoft.Json version less than 11.
NServiceBus.Newtonsoft.Json requires Newtonsoft.Json version above 11.
I can't use both in one project!
How do you will repair this problem? No, that's not important. When?

@DavidBoike
Copy link
Member

Hi @EvgenyChepurnykh,

If you step down to version 1.1 of JSON Persistence, it uses Newtonsoft.Json 10. Then you can use that with SQL Persistence.

https://www.nuget.org/packages/NServiceBus.Newtonsoft.Json/1.1.0

As for an update to SQL Persistence, we currently have a task to release a version 3.1 of that (using JSON 11) in focus and will be shipping it soon, in case you have other dependencies pushing you toward JSON 11.

@EvgenyChepurnykh
Copy link

Yes, we have updated other projects for using Newton.Json v11 because some components require v11. Now we should do a regress to determine how our project work with different versions of json. It's not easy... Anyway, thanks for the quick response....

@EvgenyChepurnykh
Copy link

Would you say, if I use Backend with Json v.11 for sending messages and nservicebus windows services with json v.10. Will I have some troubles with that configuration?

@DavidBoike
Copy link
Member

AFAIK, JSON 11 has no breaking changes at the JSON (wire-compatibility) level. It's just incompatible at the binary level, hence the new major version. So I think you could confidently have one "thing" talking in JSON 10 and exchanging that output with another "thing" using JSON 11 and be just fine.

@DavidBoike
Copy link
Member

P.S. But of course I would test that. 😉

@EvgenyChepurnykh
Copy link

Thanks for the answers and yes we will do a regress in any cases.

@EvgenyChepurnykh
Copy link

But we will wait for the update on your side :)

@SimonCropp
Copy link
Contributor Author

IMO blocking people from updating such a central dependency for over a month is not satifactory.

@SzymonPobiega SzymonPobiega changed the title Update to json newtonsoft 11.0.1 Support Newtonsoft.Json 11 Mar 26, 2018
@SzymonPobiega SzymonPobiega added this to the 3.1.0 milestone Mar 26, 2018
@SzymonPobiega
Copy link
Member

We're releasing 3.1.0 and 4.1.0-beta1

@SzymonPobiega
Copy link
Member

3.1.0 and 4.1.0-beta1 have been released.

@EvgenyChepurnykh
Copy link

Thanks :)

@SimonCropp
Copy link
Contributor Author

@SzymonPobiega thanks heaps

@weralabaj weralabaj modified the milestones: 3.1.0, 4.1.0 May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants