-
Notifications
You must be signed in to change notification settings - Fork 27
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Newtonsoft.Json 11 #258
Comments
@SimonCropp we're looking into that but we are not yet sure how to proceed with regards to versioning. |
I think release a new stable minor and a new rc |
@SimonCropp that sounds good. We were debating how to handle RC since the new RC that depends on V11 would not be a proper drop-in replacement. We are considering releasing a new RC that targets Netwonsoft [10,12) which should do the trick as from our perspective there are no breaking changes in 11. |
Hi, this is quite important for us too, because Newtonsoft.Json 11 is creeping through other nuget packages. |
bump |
@SimonCropp we're working on this |
Guys, I think it's a big trouble. We use Newtonsoft.Json v11. Sql.Persistance is uncompatible but moreover NServiceBus.Newtonsoft.Json require version 11 and above. |
If you step down to version 1.1 of JSON Persistence, it uses Newtonsoft.Json 10. Then you can use that with SQL Persistence. https://www.nuget.org/packages/NServiceBus.Newtonsoft.Json/1.1.0 As for an update to SQL Persistence, we currently have a task to release a version 3.1 of that (using JSON 11) in focus and will be shipping it soon, in case you have other dependencies pushing you toward JSON 11. |
Yes, we have updated other projects for using Newton.Json v11 because some components require v11. Now we should do a regress to determine how our project work with different versions of json. It's not easy... Anyway, thanks for the quick response.... |
Would you say, if I use Backend with Json v.11 for sending messages and nservicebus windows services with json v.10. Will I have some troubles with that configuration? |
AFAIK, JSON 11 has no breaking changes at the JSON (wire-compatibility) level. It's just incompatible at the binary level, hence the new major version. So I think you could confidently have one "thing" talking in JSON 10 and exchanging that output with another "thing" using JSON 11 and be just fine. |
P.S. But of course I would test that. 😉 |
Thanks for the answers and yes we will do a regress in any cases. |
But we will wait for the update on your side :) |
IMO blocking people from updating such a central dependency for over a month is not satifactory. |
We're releasing 3.1.0 and 4.1.0-beta1 |
3.1.0 and 4.1.0-beta1 have been released. |
Thanks :) |
@SzymonPobiega thanks heaps |
No description provided.
The text was updated successfully, but these errors were encountered: