Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script generation targets file is missing an XML namespace causing VisualStudio 2015 build to fail #246

Merged
merged 1 commit into from Dec 18, 2017

Conversation

SzymonPobiega
Copy link
Member

@SzymonPobiega SzymonPobiega commented Dec 18, 2017

This is a hotfix PR. Do not merge in github

This is a 2.2.x fix for issue #239

@SzymonPobiega SzymonPobiega self-assigned this Dec 18, 2017
@SzymonPobiega SzymonPobiega changed the title [WIP] Add missing XML namespace to MsBuild targets file Script generation targets file is missing an XML namespace causing VisualStudio 2015 build to fail Dec 18, 2017
@SzymonPobiega SzymonPobiega added this to the 2.2.2 milestone Dec 18, 2017
Copy link
Contributor

@MarcinHoppe MarcinHoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge when the build is green.

@MarcinHoppe MarcinHoppe merged commit 0ecab01 into support-2.2 Dec 18, 2017
@MarcinHoppe MarcinHoppe deleted the hotfix-2.2.2 branch December 18, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants