Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to official GitVersion latest, ignore tricky commit messages by SHA #301

Merged
merged 1 commit into from Feb 2, 2017
Merged

Update to official GitVersion latest, ignore tricky commit messages by SHA #301

merged 1 commit into from Feb 2, 2017

Conversation

DavidBoike
Copy link
Member

Fixes #277

@DavidBoike
Copy link
Member Author

@Particular/ravendb-persistence-maintainers please have a look when you're back.

mauroservienti
mauroservienti approved these changes Feb 2, 2017
View reviewed changes
Copy link
Member

@mauroservienti mauroservienti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.

@mauroservienti
Copy link
Member

Just one question: what are the commits we're ignoring?

@DavidBoike
Copy link
Member Author

The first two I threw in after looking through the git log:

Upgrade nuget packages to v6.0.0-unstable1328

Upgrade to v6.0.0-unstable1293

Remove unnecessary mocks

After I did that and the build still didn't work, I had to closely inspect the build log to find this commit, which definitely was a fail, because of the merge from a poorly named branch.

Merge pull request #127 from Particular/upgrade-v6.0.0-unstable1293

Upgrade v6.0.0 unstable1293

After your comment @mauroservienti I got curious and tried removing the first 2 SHAs and the build still worked locally, so I removed the first 2 that are apparently OK.

Lesson: No versions in branch names please!

Since I had your approval before, if TC succeeds I'll merge.

@mauroservienti
Copy link
Member

GitVersion magic 😉

@DavidBoike DavidBoike merged commit b557afc into develop Feb 2, 2017
@DavidBoike DavidBoike deleted the update-gitversion branch February 2, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauroservienti mauroservienti mauroservienti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavidBoike @mauroservienti