Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the endpoints use different database as specified in the connection string, Bus.Reply is not routed properly #59

Closed
indualagarsamy opened this issue Nov 26, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@indualagarsamy
Copy link
Contributor

When endpoints are configured to be in different databases and the connection strings are properly specified in the app.config for the endpoints, Bus.Reply is being attempted to be sent to the wrong address and fails to be sent.

Who is affected

Any endpoint running on SQLServer transport that is calling Bus.Reply() and using multi-database support via app.config connection string convention.

Problem

The connection string convention is, NServiceBus/Transport/EndpointName.

However, when using the Bus.Reply, the callback address is being used to determine the connection string and therefore fails.

When attempting to route the reply message, the address is correctly determined as:
https://github.com/Particular/NServiceBus.SqlServer/blob/master/src/NServiceBus.SqlServer/SqlServerMessageSender.cs#L41

However, instead of using the Callback address to find the connection string, the endpoint (contained in sendOptions.Destination.Queue must instead be used.
https://github.com/Particular/NServiceBus.SqlServer/blob/master/src/NServiceBus.SqlServer/SqlServerMessageSender.cs#L54

Relates to Feature: #15

indualagarsamy added a commit that referenced this issue Nov 26, 2014
@johnsimons
Copy link
Member

@indualagarsamy any chance you can add a failing acceptance test for this ?

@indualagarsamy
Copy link
Contributor Author

@johnsimons - I am looking to see if we have any acceptance tests for this feature. That was my next step.

@indualagarsamy
Copy link
Contributor Author

@andreasohlund @johnsimons - does the fix look right to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants