Testing extensions for TestableMessageSession are missing #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamralph @DavidBoike @andreasohlund Pinged you as reviewers since you might have more insights about why they were removed. Happy to close the PR in case there are reasons why they are no longer supported. Otherwise, I think it would be good to bring them back (patch or minor?) |
|
I can't remember that we removed them on purpose so 👍 to fix this |
andreasohlund
approved these changes
Jun 19, 2023
DavidBoike
reviewed
Jun 19, 2023
| @@ -300,9 +300,12 @@ namespace NServiceBus.Testing | |||
| } | |||
| public static class TestingExtensions | |||
| { | |||
| public static TMessage FindPublishedMessage<TMessage>(this NServiceBus.Testing.TestableMessageSession context) { } | |||
| public static TMessage FindPublishedMessage<TMessage>(this NServiceBus.Testing.TestablePipelineContext context) { } | |||
| public static TMessage FindReplyMessage<TMessage>(this NServiceBus.Testing.TestableMessageProcessingContext context) { } | |||
There was a problem hiding this comment.
Why not FindReplyMessage on TestableMessageSession as well?
There was a problem hiding this comment.
ReplyMessages only exist on TestableMessageProcessingContex. TestableMessageSession doesn't even have the property.
DavidBoike
approved these changes
Jun 19, 2023
DavidBoike
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533
Brings back extension methods for
TestableMessageSessionthat were accidentally removed as part of #274