Skip to content

Commit

Permalink
fix corrupted merge for headermapper
Browse files Browse the repository at this point in the history
  • Loading branch information
SimonCropp committed Aug 15, 2013
1 parent f158cd9 commit 41a3b8c
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/NServiceBus.Core/Gateway/HeaderManagement/HeaderMapper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ public static TransportMessage Map(IDictionary<string, string> from)
{
if (!from.ContainsKey(GatewayHeaders.IsGatewayMessage))
{
return new TransportMessage();
}

var message = new TransportMessage();
foreach (var header in from)
{
message.Headers[header.Key] = header.Value;
Expand Down Expand Up @@ -41,7 +39,6 @@ public static TransportMessage Map(IDictionary<string, string> from)
{
to.TimeToBeReceived = MinimumTimeToBeReceived;
}
}

return to;
}
Expand Down Expand Up @@ -99,7 +96,7 @@ static string StripSlashZeroFromCorrelationId(string corrId)
return corrId;
}

[ObsoleteEx(RemoveInVersion = "5.0", TreatAsErrorFromVersion = "5.0")]
[ObsoleteEx(RemoveInVersion = "5.1", TreatAsErrorFromVersion = "5.0")]
static void SetBackwardsCompatibilityHeaders(IDictionary<string, string> to)
{
if (Configure.HasComponent<MsmqMessageSender>())
Expand Down

5 comments on commit 41a3b8c

@SimonCropp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasohlund we had a corrupted merge. I patched it with this commit. can u review. CC @johnsimons @indualagarsamy

@johnsimons
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Everyone slap @andreasohlund 😄

@andreasohlund
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I blame a faulty chair to keyboard connection:)

@indualagarsamy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Question, unrelated to this commit, but related to the file where changes are made.
There are some methods that only have RemoveInVersion, and it doesn't have the TreatAsErrorFromVersion. Is that intended?

@SimonCropp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indualagarsamy if u leave one out the other is inferred

Please sign in to comment.