-
Notifications
You must be signed in to change notification settings - Fork 648
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix corrupted merge for headermapper
- Loading branch information
1 parent
f158cd9
commit 41a3b8c
Showing
1 changed file
with
2 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41a3b8c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreasohlund we had a corrupted merge. I patched it with this commit. can u review. CC @johnsimons @indualagarsamy
41a3b8c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Everyone slap @andreasohlund 😄
41a3b8c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I blame a faulty chair to keyboard connection:)
41a3b8c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Question, unrelated to this commit, but related to the file where changes are made.
There are some methods that only have RemoveInVersion, and it doesn't have the TreatAsErrorFromVersion. Is that intended?
41a3b8c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@indualagarsamy if u leave one out the other is inferred