MessageModule.HandleError should log an Error when it throws

[SimonCropp]

When HandleEndMessage or HandleBeginMessage throw an Error is logged

However when HandleError is called a Warn is logged.

[johnsimons]

I'm pretty sure this is by design, see 94c74fb

So we only log a error when the message is sent to the error queue.

[SimonCropp]

this exception is not sent to the error queue

[johnsimons]

this exception is not sent to the error queue

Yes that is correct, that happens later on

[SimonCropp]

nope. only the exception from the handler is appended to the error queue headers. not the exception from the MessageModule.HandleError

[johnsimons]

That is not nice 😞

So any exception in a messagemodule does not get added to the error message?

[johnsimons]

Also, I'm getting confused because in your link above you are pointing to TransportReceiver but you are actually talking about message modules, is the link right?

[SimonCropp]

the link is correct

here is a test to debug. https://github.com/Particular/NServiceBus/blob/removeStackTraceTweaks/src/NServiceBus.AcceptanceTests/ExceptionHandling/When_Module_Error_throws.cs although u may want to do it on master since that branch has moved on a little

[SimonCropp]

fixed in d414f49