Obsolete Saga.RequestTimeout(Action<TTimeoutMessageType>)

[SimonCropp]

Both have new() constraints and hence cannot be an interface. No need to construct an instance when the consumer can do this themselves.

RequestTimeout<TTimeoutMessageType>(TimeSpan within, Action<TTimeoutMessageType> messageConstructor) where TTimeoutMessageType : new()
RequestTimeout<TTimeoutMessageType>(DateTime at, Action<TTimeoutMessageType> action) where TTimeoutMessageType : new()

[SimonCropp]

same for ReplyToOriginator<TMessage>(Action<TMessage> messageConstructor)

[johnsimons]

@SimonCropp @andreasohlund,

I actually think we need to remove the new() constraints and also roll back #2498.
Users should be able to pass interfaces to those overload methods.

This is related to the issue that we have just patched not long ago regarding #2446.

So in summary users should be allowed to delay any incoming message including events.
So the following code should work:

public class MySaga : Saga<MySagaData>,
    IAmStartedByMessages<OrderShipped>,
    IHandleTimeouts<OrderShipped>
{
    public void Handle(OrderShipped message)
    {
        RequestTimeout<OrderShipped>(TimeSpan.FromSeconds(25), message);
    }

    public void Timeout(OrderShipped state)
    {

    }
}

interface OrderShipped : IEvent
{
}

[andreasohlund]

When you request the TM you already have the instantiated message?

Sent from my iPhone

On 19 Oct 2014, at 23:15, John Simons notifications@github.com wrote:

@SimonCropp @andreasohlund,

I actually think we need to remove the new() constraints and also roll back #2498.
Users should be able to pass interfaces to those overload methods.

This is related to the issue that we have just patched not long ago regarding #2446.

So in summary users should be allowed to delay any incoming message including events.
So the following code should work:

public class MySaga : Saga,
IAmStartedByMessages,
IHandleTimeouts
{
public void Handle(OrderShipped message)
{
RequestTimeout(TimeSpan.FromSeconds(25));
}

public void Timeout(OrderShipped state)
{

}

}

interface OrderShipped : IEvent
{
}
—
Reply to this email directly or view it on GitHub.