Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect NHibernate nuget package dependency #2638

Closed
particularbot opened this issue Jan 29, 2015 · 7 comments
Closed

Incorrect NHibernate nuget package dependency #2638

particularbot opened this issue Jan 29, 2015 · 7 comments
Labels
Milestone

Comments

@particularbot
Copy link
Contributor

Symptoms

Assembly resolution errors occur when NServiceBus attempts to load NHIbernate

Resolution

Correct the NServiceBus.NHibernate nuspec to point to 3.3.0.4000 of Nhibernate instead of 3.3.1.4000


I’ve been able to get rid of the warning by reverting to NHibernate v3.3.0.4000 and FluentNHibernate v1.3.0.727. 

(From 3.3.1.4000 & 1.4.0.0) It’s a little frustrating because I will have to go back and repull, recompile, and repush a lot of our internal framework to align the NHibernate stuff to be the same version across the board. 

I would suggest either updating the Dependency noted in NuGet, or pushing an update that actually uses the version referenced.


If you can let me know what your plan of action is regarding this, then I can respond appropriately. 
I can hold of a day or two if you think you will update the package dependency, then I won’t need to change as much, otherwise, I need to redo my Plexis Framework packages. 

My services will not work if one is referencing 3.3.1.4000 and another is on 3.3.0.4000. I have 11 foundational & framework DLLs and about 14 projects in my first service alone. 
(We are targeting 7 services for this release). If I have to change stuff once, fine. 
If I don’t have to change it all, even better. 
But I want to avoid changing it only to have you update the package so I end up changing yet a second time. 
I already have a headache from all this DLL versioning nightmare.

So please let me know which of the following regarding using NHibernate with NServiceBus 3.3.13.0:

1. Do I go ahead and build using NHibernate v3.3.0.4000 and FluentNHibernate v1.3.0.727?

a. You should update the Nuget page to define the Dependency as NHibernate 3.3.0.4000

2. Or should I stay with NHibernate v3.3.1.4000 and FluentNHibernate v1.4.0.0 as defined by Nuget and you will update your NServiceBus.NHibernate 3.3.13 package so it actually uses the version noted.

image001
image004

@johnsimons
Copy link
Member

@andreasohlund this is a 3.3 bug but not critical, do we patch or not ?

@andreasohlund
Copy link
Member

Is the fix easy? If yes we could include it the next time we have to patch 3.3?

@johnsimons
Copy link
Member

@andreasohlund yes pretty sure is a trivial update, sounds like a good plan to patch it as part of next 3.3 release.

@johnsimons johnsimons added this to the 3.3.15 milestone Feb 2, 2015
@indualagarsamy
Copy link
Contributor

@johnsimons - any updates on this? Can you describe the root cause and add more details?

@johnsimons
Copy link
Member

@indualagarsamy we just need to update the dependency in the nuget spec file, do you need me to do that ?

@andreasohlund
Copy link
Member

Should we go ahead and release this together with th vs2015 fix?

@indualagarsamy
Copy link
Contributor

@andreasohlund - yes. I think so.

@SimonCropp SimonCropp changed the title Nuget package dependancy issues reported by David Cannon Incorrect NHibernate nuget package dependency Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants