Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSMQ requires error queue configuration for send-only endpoints #4769

Closed
boblangley opened this issue May 31, 2017 · 11 comments · Fixed by Particular/NServiceBus.Transport.Msmq#25
Labels
Milestone

Comments

@boblangley
Copy link
Member

boblangley commented May 31, 2017

Who's affected

Anyone using the MSMQ transport with send-only endpoints on NServiceBus 6.3.

Symptoms

After upgrading to 6.3, users need to configure a error queue unnecessarily.

Original bug report

This is a change in behavior and has broken the Azure dynamic host, which launches the endpoint as a sendonly endpoint.

@boblangley boblangley added the Bug label May 31, 2017
@boblangley
Copy link
Member Author

This line should include a check to see if the endpoint is not configured as a SendOnly endpoint: https://github.com/Particular/NServiceBus/blob/master/src/NServiceBus.Core/Transports/Msmq/MsmqTransport.cs#L35

@SeanFeldman
Copy link
Contributor

SeanFeldman commented May 31, 2017

I've raised a PR against MSMQ transport: Particular/NServiceBus.Transport.Msmq#25

@andreasohlund
Copy link
Member

Would we classify this as a patch?

@SeanFeldman
Copy link
Contributor

I'd say so. Qualifies at least a Minor Patch criteria as azure multi host would require to take the host offline, add an error queue configuration and redeploy. That's quite a workaround 😃

@andreasohlund
Copy link
Member

How can the azure multi host be affected by a msmq bug?

@yvesgoeleven
Copy link
Contributor

@andreasohlund as discussed on slack, it's probably because msmq is on by default as the host doesn't have a need for a transport

@bording
Copy link
Member

bording commented Jun 1, 2017

Reopening since we still need to consider a 6.3.x patch.

@SimonCropp
Copy link
Contributor

wouldnt this always fail at startup? in which case it could never get to production? and if so not a back port

@bording
Copy link
Member

bording commented Jun 7, 2017

@SimonCropp It's not a backport. It's a fix to a regression introduced in 6.3.0

@SimonCropp
Copy link
Contributor

@bording ok thanks for the clarification

@bording bording changed the title MSMQ in 6.3 requires setting error queue when set as SendOnly endpoint MSMQ requires error queue configuration for send only endpoints Jun 7, 2017
@bording bording added this to the 6.3.4 milestone Jun 7, 2017
@bording bording changed the title MSMQ requires error queue configuration for send only endpoints MSMQ requires error queue configuration for send-only endpoints Jun 7, 2017
@bording
Copy link
Member

bording commented Jun 7, 2017

Fixed by #4784

@bording bording closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants