Added locking logic to AzureMessageQueueReceiver.GetMessage to resolve failure to get messages from queue. #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eueReceiver to make AzureMessageQueueReceiver.GetMessage thread-safe.
|
@joeschick can you add a unit test that verifies this fix? |
|
how about this as an alternative? 786759a |
|
786759a looks good, nice code cleanup. I don't have a unit test for it. I debugged down to AzureMessageQueueReceiver.GetMessage, saw the lack of thread-safety, made it thread-safe, and the issue was resolved. In my application the issue was intermittent, but happened very frequently. The most obvious occurrences being 100+ subscription messages just sitting in queues with endpoints running as though the queues were empty. How do you suggest writing a unit test for an intermittent issue such as this one? |
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to concurrent access and the lack of thread-safety, AzureMessageQueueReceiver.GetMessage is, on occasion, failing to read messages from the input queue. There aren't any exceptions, just no messages processed after queue.BeginGetMessages completes, even though there are messages in the input queue. With the addition of the locking logic, the issue appears to be resolved.