Fixing bug in distributor not notified about worker ready when handling message of to SLR

[SzymonPobiega]

Related to this change in distributor

• Added raising FinishedMessageProcessing when handing msg off to SLR
• Moved raising StartedMessageProcessing so that it is invoked even for messages without ID

Related to Particular/NServiceBus.Distributor.Msmq#22

[SzymonPobiega]

@andreasohlund @SimonCropp @johnsimons pls review

[andreasohlund]

Looks good to me.

Side note: #2521

[andreasohlund]

@SzymonPobiega build error?

[indualagarsamy]

@SzymonPobiega - squashing commits will be a good idea, especially when we are back porting this fix.

[SzymonPobiega]

The builds for this branch seem to be good:
http://builds.particular.net/viewLog.html?buildId=60380&tab=buildResultsDiv&buildTypeId=NServiceBusCore_Build
http://builds.particular.net/viewLog.html?buildId=60382&tab=buildResultsDiv&buildTypeId=NServiceBus_2RunAcceptanceTestsForMsmq

Isn't the pull request build trying to merge that to develop and that's why it is failing (based on version number the extended obsolete is causing the failure)

[SzymonPobiega]

@indualagarsamy as git beginner, not sure which approach for squashing is best. All the options listed here http://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git seems to me equally good. What's in your opinion the best?

[indualagarsamy]

@SzymonPobiega - :) You'll get a different answer from @johnsimons.
I prefer GitBash and the git command prompt
I use this approach http://stackoverflow.com/questions/6934752/combining-multiple-commits-before-pushing-in-git

[johnsimons]

This looks good, going to merge it

[SimonCropp]

i think many of these props are redundant

[johnsimons]

We also need to patch https://github.com/Particular/NServiceBus/blob/4.7.1/src/NServiceBus.Core/Distributor/ReadyMessages/ReadyMessageSender.cs

[johnsimons]

Merged