[Obsolete] Old Hotfix 3.3.16 PR #3008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
force-pushed
the
hotfix-3.3.16
branch
from
10dab94
to
4701328
Compare
|
Hotfix branch 3.3.16 taken by @weralabaj Branch renamed to 3.3.17 and created new PR #3010 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to Particular/PlatformDevelopment#423
Still work in progress, basically a backport of the v4.x backport :-) files are almost identifical but at a different location.
Only difficulty is that the builder does not have the ability to get a resolve an object. First did a hack by using an Lazy then I realized that I can probably just get the IBus instance injected if the IBus Bus property is defined.