Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report first-time install metric to Particular when a user installs NServiceBus #4280

Merged
merged 9 commits into from Nov 17, 2016
Merged

Report first-time install metric to Particular when a user installs NServiceBus #4280

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bdbb160
Relates to https://github.com/Particular/OptimizeTrialExtensions/issu…
Nov 8, 2016
40fed24
final tweaks after testing
Nov 8, 2016
fb0722b
Changing the api to reflect the install metric and not the usage metric.
Nov 9, 2016
57a1c62
Remove UploadValuesAsync and convert to background job
Nov 15, 2016
b965195
Make sure that the user is notified in the console.
Nov 16, 2016
750905f
Rework to show text only once
Nov 17, 2016
b4b873e
Update notice text
Nov 17, 2016
06a262c
cleanup
Nov 17, 2016
b32adb9
Clean up extra blank Lines
bording Nov 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 12 additions & 7 deletions packaging/nuget/tools/init.ps1
View file
Open in desktop
Expand Up @@ -33,14 +33,19 @@ try {

Set-ItemProperty -Path $platformKeyPath -Name "NuGetUser" -Value "true" | Out-Null


$url = "http://particular.net/download-the-particular-service-platform?version=$packageVersion"
$url = $url.ToLowerInvariant();

if($dte){
$dte.ExecuteCommand("View.URL", $url)
}
Write-Verbose 'Reporting first time install and version information to www.particular.net. This call does not collect any personal information. For more details, see the License Agreement and the Privacy Policy available here: http://particular.net/licenseagreement. Subsequent NuGet installs or updates will not invoke this call.' -verbose
$url = 'https://particular.net/api/ReportFirstTimeUsage'
$postData = New-Object System.Collections.Specialized.NameValueCollection
$postData.Add("version", $packageversion)
$wc = New-Object System.Net.WebClient
$wc.UseDefaultCredentials = $true
$wc.UploadValuesAsync($url,"post", $postdata)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we don't catch the exception here, what happens with the script if an exception is thrown? is that swallowed the same way as in a c# app or will this break the script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timbussmann - I have tested this scenario with a bad url. It does not break the script.
I also tested it by disabling the network adapter and running the nuget install (from local source), errors do not get reported.

}
Catch [Exception] {
Write-Warning $error[0]
}
finally {
if ($wc){
$wc.Dispose()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this guaranteed to work? According to the doco upload async asynchronously uploads without blocking which means the finally block can be executed during the upload.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmarbach - See http://stackoverflow.com/questions/1999858/how-bad-is-it-to-not-dispose-in-powershell

As far as I know, the call will execute asynchronously, even after the package manager is done and back to the console. I tested this by running the backend locally and set a breakpoint. The nuget install completed and got back to the prompt but the code was still invoked and waiting at the breakpoint I set.

Also this is a one time thing. We are not calling this script over and over. IMO, it shouldn't have any impact. What exact changes are you requesting here? Do you have any suggestions of what I can add here in the powershell?

@gbiellem - your thoughts on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what @danielmarbach is getting at is since the powershell script is never awaiting the result of the async UploadValuesAsync call, that means the finally block could be executed and dispose the WebClient before the call finishes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct what @bording said

}
}