Do not enable installers when running in debug mode #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
previously approved these changes
Sep 19, 2017
bording
reviewed
Sep 19, 2017
| @@ -28,7 +29,8 @@ class EndpointWithInstaller : EndpointConfigurationBuilder | |||
| { | |||
| public EndpointWithInstaller() | |||
| { | |||
| EndpointSetup<DefaultServer>(c => c.DisableInstallers()); | |||
| // disable installers as installers are enabled by default in DefaultServer | |||
| EndpointSetup<DefaultServer>(c => c.GetSettings().Set("Installers.Enable", false)); | |||
There was a problem hiding this comment.
I guess this is OK, but I'd almost prefer to see it use another template so that we didn't have to do something special here.
@timbussmann What failure are you having with them? |
|
I've pushed up the API approval, so removing the WIP from this. |
bording
changed the title
andreasohlund
approved these changes
Sep 20, 2017
@bording the created file paths of the approval files were somewhere on a temp directory and not the ones in the git repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer automatically enable installers when running in debug mode. With this change, we no longer need the
DisableInstallersAPI.WIP as I can't get the approval tests working correctly when running the tests in R# /cc @bording