CancellationToken analyzer and code fixer #5867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
DavidBoike
force-pushed
the
token-on-context
branch
from
d85d4b2
to
2cbb4af
Compare
…nly match a method that could be fixed.
…actually do (failing tests)
DavidBoike
force-pushed
the
token-on-context
branch
from
2645cf9
to
1577ad8
Compare
|
@andreasohlund @adamralph This PR should be ready to review now. Analyzer/fixer should handle handlers, timeouts, behaviors, and IHandleSagaNotFound. |
andreasohlund
approved these changes
Jan 29, 2021
adamralph
changed the title
|
Replaced by #5923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will need to edit the analyzer after IMessageHandlerContext methods gain CancellationTokens in order to have the analyzer ignore NServiceBus calls where the pipeline will already know about the cancellation token.