Persistence Tests - Make sure stale records are modified before save #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Daniel Marbach <daniel.marbach@openplace.net>
|
I updated the description of the PR |
danielmarbach
changed the title
danielmarbach
approved these changes
Nov 24, 2022
mauroservienti
added a commit
that referenced
this pull request
Nov 24, 2022
…6603) * Make sure stale records are modified before save Co-Authored-By: Daniel Marbach <daniel.marbach@openplace.net> * Update the stale record outside the Assert Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
mauroservienti
added a commit
that referenced
this pull request
Nov 24, 2022
…6603) * Make sure stale records are modified before save Co-Authored-By: Daniel Marbach <daniel.marbach@openplace.net> * Update the stale record outside the Assert Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns
When_updating_saga_concurrently_on_same_threadWhen_updating_saga_concurrently_twice_on_the_same_threadwith
When_updating_saga_concurrently_on_different_threadwhich already does update a property of the saga.It is required to update something on the saga otherwise persisters like RavenDB that can discover whether something has change or not will simply not execute any side effect because the document hasn't been updated which then also doesn't trigger a concurrency conflict.
Backported to