Introducing some nullable reference type support on public APIs #6757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/NServiceBus.Core.Tests/ApprovalFiles/APIApprovals.ApproveNServiceBus.approved.txt
Show resolved
Hide resolved
|
@DavidBoike the usage of the guard class requires an update to make this PR compile |
|
@danielmarbach Yep, adjusted that, and added an approval test to list types that do not have nullable annotations. That list should shrink over time, growth should not be approved. |
DavidBoike
approved these changes
Jun 12, 2023
|
Nice! |
DavidBoike
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements nullable reference type support on some of the more important classes in the public API.
Includes additional approval tests (which were augmented in #6772) to keep track of what public types are not yet annotated, and to make sure that the nullable-supporting API interface does not regress.