Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand environment variables in the learning transport connection string #1998

Merged
merged 2 commits into from May 1, 2020

Conversation

ramonsmits
Copy link
Member

This make it possible to do for example %TEMP%\.learningTransport

This make it possible to do for example `%TEMP%\.learningTransport`
@ramonsmits ramonsmits force-pushed the learningtransport-expand-connectionstring branch from 8a62714 to 1ca2135 Compare May 1, 2020 12:26
@ramonsmits ramonsmits self-assigned this May 1, 2020
@danielmarbach
Copy link
Contributor

This will only properly work if you do it also for LearningTransportCustomization connection strings where we set the storage directory. Pushed an update

@danielmarbach
Copy link
Contributor

I actually think this would be a great feature enhancement to Core @ramonsmits Maybe send in a to the core learning transport?

@ramonsmits
Copy link
Member Author

@danielmarbach I considered that first but as learning transport is initialized via code in core and not via a connection string (I think..) adding ENVVAR expanding is up to the developer.

@danielmarbach danielmarbach merged commit 1baec76 into master May 1, 2020
@danielmarbach danielmarbach deleted the learningtransport-expand-connectionstring branch May 1, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants