-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run as service introduced by and logging initialization vs configuration order #2039
Conversation
23c943f
to
0f74b57
Compare
… change to all instance types. Added `--portable` option to monitoring as it had no way to run as "non-interactive console".
…e early start but settings for it were initialized in Host, Commands and SetupBootstrapper having no effect in logging as logging was already initialized. Copied solution from SC instance to audit and monitoring, and also fixed that monitoring was not logging to console at all
0f74b57
to
eed2028
Compare
@ramonsmits unfortunately this probably requires a rebase now |
Hey @ramonsmits , Any updates on this? is this still on the radar for your team? Thank you! |
@TraGicCode We have reverted the behavior of the hosting and logging at the last related change broke hosting and logging. We provided a workaround to log to console by providing an |
Thanks for replying, I will give that a shot and see if i have any issues |
Hi, @TraGicCode I'm trying to figure out what is the scenario that you need the custom |
Hey @tmasternak , sorry for getting back to you so late. My puppet module for servicecontrol has a task that allows someone to automatically re-import failed audit and error messages. Unfortunately servicecontrol was logging but not logging to stdout which is what puppet uses to display output back to the user. @ramonsmits revommended above I needed to customize nlog for this to happen. Do you know if this is still required? |
Hi @TraGicCode, In the latest version, ServiceControl logs to the console when executing an error or audit messages re-import. |
Hey @tmasternak , Let me test this and get back with my results. |
Hey @tmasternak , Everything appears to be working fine for me. Thanks! |
Glad to hear that :). Thank you for verification @TraGicCode. |
Fixes #2031
Fixes #2002
Fixes #2017
User reported in #2031 that windows service control manager behaved strangely. Testing this indicated it was not run as a service resulting in this strange behavior. While fixing this I noticed that logging was initialized early while 'the print to console' setting was set after logging was already initialized.