Clean FailedMessageRetry when FailedMessage is cleaned #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
previously approved these changes
Aug 7, 2020
danielmarbach
previously approved these changes
Aug 7, 2020
danielmarbach
force-pushed
the
clean-retries-with-expired
branch
from
e5f5e0e
to
9d5ecdf
Compare
|
Rebased |
danielmarbach
previously approved these changes
Aug 8, 2020
danielmarbach
previously approved these changes
Aug 8, 2020
...viceControl.AcceptanceTests/Recoverability/MessageFailures/FailedMessageRetriesController.cs
Show resolved
Hide resolved
src/ServiceControl/Infrastructure/RavenDB/Expiration/ErrorMessageCleaner.cs
Show resolved
Hide resolved
src/ServiceControl.UnitTests/ApprovalFiles/APIApprovals.PublicClr.approved.txt
Outdated
Show resolved
Hide resolved
danielmarbach
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial fix for #2019