Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New-ServiceControlAuditInstance PowerShell cmdlet fails since v4.15 #2395

Merged
merged 1 commit into from Jan 14, 2021
Merged

New-ServiceControlAuditInstance PowerShell cmdlet fails since v4.15 #2395

merged 1 commit into from Jan 14, 2021

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Jan 14, 2021 •
edited by mauroservienti

Adds a package reference to the Particular.Licensing package in the ServiceControl.Audit project. If the reference is missing the generated exe is not stamped with the ReleaseDateAttribute. The attribute causes the ReleadeDateReader used by unattended installations (e.g. PowerShell) to fail.

Backport of #2391 to release-4.15

@mauroservienti
Copy link
Member

Shouldn't this target release-4.15?

@mauroservienti mauroservienti changed the base branch from master to release-4.15 January 14, 2021 09:49
@mauroservienti mauroservienti added this to the 4.15.1 milestone Jan 14, 2021
@danielmarbach
Copy link
Contributor Author

yes it should

@ramonsmits
Copy link
Member

I thought we didn't backport on SC?

@danielmarbach
Copy link
Contributor Author

Depends on #2398

@ramonsmits
Copy link
Member

Depends on #2398

Why not select time-server-update as the base branch? GH will auto-update this is that PR gets merged.

@danielmarbach
Copy link
Contributor Author

It will anyway be rebuild against the latest updates once the other is merged

@mauroservienti mauroservienti merged commit 6b6256d into release-4.15 Jan 14, 2021
@mauroservienti mauroservienti deleted the back-audit-release-date branch January 14, 2021 15:55
@ramonsmits ramonsmits changed the title Add a reference to Particular.Licensing to make so that ServiceControl.Audit gets a ReleaseDate attribute Fixes PowerShell Cmdlet New-ServiceControlAuditInstance failing since 4.15 Jan 15, 2021
@adamralph adamralph changed the title Fixes PowerShell Cmdlet New-ServiceControlAuditInstance failing since 4.15 New-ServiceControlAuditInstance PowerShell cmdlet fails since v4.15 Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauroservienti mauroservienti mauroservienti approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
4.15.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielmarbach @mauroservienti @ramonsmits