Remove the IsDebugEnabled check from audit expiration #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
approved these changes
Jan 31, 2022
| { | ||
| logger.Debug($"Batching deletion of {s}-{e} saga history documents."); | ||
| } | ||
| logger.Debug($"Batching deletion of {s}-{e} saga history documents."); |
There was a problem hiding this comment.
This is a more general comment for all changes in this PR, where we still use interpolation. For consistency, would it make sense to also use the format-based overloads, like you did in some other changes in this PR?
There was a problem hiding this comment.
I've actually gone the other way and have gone for interpolation rather than using the format overloads. My reasons:
- It's easier to read what the value is when compared to looking at the index number and comparing to the args array
- If we support structured logging in the future, we may be able to pull more meaning from the logs.
There was a problem hiding this comment.
I'm not an expert on this. If I read this right, we would have to use the template-based approach outlined in
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-6.0#log-message-template
docs.microsoft.comdocs.microsoft.com
Which means "not using interpolation".
src/ServiceControl/Infrastructure/RavenDB/Expiration/ExpiredDocumentsCleaner.cs
Show resolved
Hide resolved
src/ServiceControl.Audit/Infrastructure/RavenDB/EmbeddedRavenDbHostedService.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsDebugEnabledappears to be incorrectly set tofalsepossibly due to caching of the value in core. This makes it impossible to get insight into the expiration cleanup process.This PR removes the
IsDebugEnabledcheck from the expiration process. This process is not on the hot path for ingestion so skipping the check here should not incur a major performance penalty.