Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only expose RavenDB 5 on localhost #3270

Merged
merged 1 commit into from Dec 2, 2022
Merged

Only expose RavenDB 5 on localhost #3270

merged 1 commit into from Dec 2, 2022

Conversation

andreasohlund
Copy link
Member

Fixes #3264

@andreasohlund andreasohlund added this to the 4.27.0 milestone Dec 1, 2022
@andreasohlund andreasohlund self-assigned this Dec 1, 2022
mikeminutillo
mikeminutillo approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@mikeminutillo mikeminutillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a consequence of this, the database will not be available outside of the local server, even in maintenance mode. I don't think that's an issue but it should probably be mentioned in the documentation somwhere.

@andreasohlund
Copy link
Member Author

@mikeminutillo docs already states that localhost must be used

https://docs.particular.net/servicecontrol/audit-instances/creating-config-file#troubleshooting-ravendb-5

where

3.5 points out that hostname also works

https://docs.particular.net/servicecontrol/audit-instances/creating-config-file#troubleshooting-ravendb-3-5

@andreasohlund andreasohlund merged commit 2f56f44 into master Dec 2, 2022
@andreasohlund andreasohlund deleted the only-use-localhost branch December 2, 2022 06:42
@andreasohlund andreasohlund removed this from the 4.27.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauroservienti mauroservienti mauroservienti left review comments

@mikeminutillo mikeminutillo mikeminutillo approved these changes

Assignees

@andreasohlund andreasohlund

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit instances can't be installed using a custom hostname
3 participants
@andreasohlund @mikeminutillo @mauroservienti