Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the experience when running and debugging ServiceControl instances locally #3528

Merged
merged 66 commits into from
May 24, 2023
Merged

Improve the experience when running and debugging ServiceControl instances locally #3528

merged 66 commits into from
May 24, 2023

Commits on May 17, 2023

  1. Extend assembly resolve logic to look into the transports subfolder

    @mauroservienti
    mauroservienti committed May 17, 2023
    Configuration menu
    Copy the full SHA
    0e7565d View commit details
    Browse the repository at this point in the history

  2. Make sure all transports are built and copy build output into the pro… 

    …ject dir output
    @mauroservienti
    mauroservienti committed May 17, 2023
    Configuration menu
    Copy the full SHA
    958d250 View commit details
    Browse the repository at this point in the history

  3. Exclude log files, the diagnostic directory and the Transports folder

    @mauroservienti
    mauroservienti committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d723b27 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Extract reusable properties and do not manually copy files 

    Co-Authored-By: Jo Palac <jpalac@users.noreply.github.com>
    @mikeminutillo @jpalac
    mikeminutillo and jpalac committed May 18, 2023
    Configuration menu
    Copy the full SHA
    94b88ca View commit details
    Browse the repository at this point in the history

  2. Make commands accept settings instead of loading them internally

    @mauroservienti
    mauroservienti committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3875321 View commit details
    Browse the repository at this point in the history

  3. Add transport manifests

    @mauroservienti
    mauroservienti committed May 18, 2023
    Configuration menu
    Copy the full SHA
    a3178f3 View commit details
    Browse the repository at this point in the history

  4. Update the settings class to handle transport type and transport name 

    Transport name takes precedence
    @mauroservienti
    mauroservienti committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c5f7ef4 View commit details
    Browse the repository at this point in the history

  5. Add persisters props and support to copy persisters in Audit output dir

    @mauroservienti
    mauroservienti committed May 18, 2023
    Configuration menu
    Copy the full SHA
    3f212e3 View commit details
    Browse the repository at this point in the history

  6. Update assembly resolution to take into account transports and perist… 

    …ers folders
    @mauroservienti
    mauroservienti committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ceeaac7 View commit details
    Browse the repository at this point in the history

  7. Restore settings constructor and make the transport and persister typ… 

    …e take precedence
    @mauroservienti
    mauroservienti committed May 18, 2023
    Configuration menu
    Copy the full SHA
    1a85506 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. update approval files

    @jpalac
    jpalac committed May 19, 2023
    Configuration menu
    Copy the full SHA
    3580400 View commit details
    Browse the repository at this point in the history

  2. modify app.config to use transport and persistence name

    @jpalac
    jpalac committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dd1c7d5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #3526 from Particular/audit-F5-experience 

    Audit instance F5 experience
    @jpalac
    jpalac committed May 19, 2023
    Configuration menu
    Copy the full SHA
    0e25011 View commit details
    Browse the repository at this point in the history

  4. added transport manifest read from file to monitoring instance

    @jpalac
    jpalac committed May 19, 2023
    Configuration menu
    Copy the full SHA
    a8459b5 View commit details
    Browse the repository at this point in the history

  5. Use uniform naming across instances and have audit load transports th… 

    …e same way as monitoring
    @jpalac
    jpalac committed May 19, 2023
    Configuration menu
    Copy the full SHA
    1c0c604 View commit details
    Browse the repository at this point in the history

  6. Remove unused using

    @mikeminutillo
    mikeminutillo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    2fb51dd View commit details
    Browse the repository at this point in the history

  7. Use transport manifest in primary instance

    @mikeminutillo
    mikeminutillo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    f12864e View commit details
    Browse the repository at this point in the history

  8. removed redundant validation logic

    @jpalac
    jpalac committed May 19, 2023
    Configuration menu
    Copy the full SHA
    4df30e9 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'F5-experience' of https://github.com/Particular/Service… 

    …Control into F5-experience
    @jpalac
    jpalac committed May 19, 2023
    Configuration menu
    Copy the full SHA
    884d953 View commit details
    Browse the repository at this point in the history

  10. Primary instance F5 experience 

    Co-Authored-By: Mauro Servienti <1325611+mauroservienti@users.noreply.github.com>
    @mikeminutillo @mauroservienti
    mikeminutillo and mauroservienti committed May 19, 2023
    Configuration menu
    Copy the full SHA
    e0a34ff View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Change transport manifest to always have a definition

    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    ebc0e7f View commit details
    Browse the repository at this point in the history

  2. Update TransportCustommizationType to TransportType in Primary so it'… 

    …sthe same across all instances
    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    f6b80df View commit details
    Browse the repository at this point in the history

  3. Move aliases into transport manifest

    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    910ee5c View commit details
    Browse the repository at this point in the history

  4. consolidate app.config TransportType and TransportName settings

    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    73d742c View commit details
    Browse the repository at this point in the history

  5. config fix

    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    0e219d5 View commit details
    Browse the repository at this point in the history

  6. removed TransportName from app.configs

    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    9433a98 View commit details
    Browse the repository at this point in the history

  7. fix passed in transportType not being used

    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d324a77 View commit details
    Browse the repository at this point in the history

  8. Added reading of persistence manifest files to match transport manife… 

    …st behaviour

Fixed approval tests
    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    93ba303 View commit details
    Browse the repository at this point in the history

  9. Fix unit tests

    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    0506c8a View commit details
    Browse the repository at this point in the history

  10. Fixed setup tests 

    Added commented out config settings for transport and persisters
    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    0f55ef9 View commit details
    Browse the repository at this point in the history

  11. fix transport approval test

    @jpalac
    jpalac committed May 22, 2023
    Configuration menu
    Copy the full SHA
    69bb452 View commit details
    Browse the repository at this point in the history

  12. Bypass command index 

    Azure/azure-cli#26272 (comment)
    @mikeminutillo
    mikeminutillo committed May 22, 2023
    Configuration menu
    Copy the full SHA
    885ca0d View commit details
    Browse the repository at this point in the history

  13. Fix typos in RabbitMQ transport manifest

    @mauroservienti
    mauroservienti committed May 22, 2023
    Configuration menu
    Copy the full SHA
    9989a84 View commit details
    Browse the repository at this point in the history

  14. Fix monitoring instance assembly resolution to look into the configur… 

    …ed transport subfolder
    @mauroservienti
    mauroservienti committed May 22, 2023
    Configuration menu
    Copy the full SHA
    6545243 View commit details
    Browse the repository at this point in the history

  15. Transport manifest's Aliases can be null

    @mauroservienti
    mauroservienti committed May 22, 2023
    Configuration menu
    Copy the full SHA
    54afb13 View commit details
    Browse the repository at this point in the history

  16. Additional required settings for RavenDB 5

    @mauroservienti
    mauroservienti committed May 22, 2023
    Configuration menu
    Copy the full SHA
    201eb4a View commit details
    Browse the repository at this point in the history

  17. Comment RavenDB 3.5 InMemory option and separate settings for better … 

    …readability
    @mauroservienti
    mauroservienti committed May 22, 2023
    Configuration menu
    Copy the full SHA
    04cb8f2 View commit details
    Browse the repository at this point in the history

  18. Update RavenDB 5 EmbeddedDatabase to understand folder structure and … 

    …binaries location when necessary
    @mauroservienti
    mauroservienti committed May 22, 2023
    Configuration menu
    Copy the full SHA
    9ff734b View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Add null check for transportFolder

    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0e28daf View commit details
    Browse the repository at this point in the history

  2. Added TransportManifestLibrary tests 

    Modified search to also look at executing assembly to allow for loading during tests
    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    49955ac View commit details
    Browse the repository at this point in the history

  3. Added persistenceManifestLibrary tests 

    Modified search to also look at executing assembly to allow for loading during tests
Changed persistence maniafest file to be audit specific
    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    54e6523 View commit details
    Browse the repository at this point in the history

  4. Added transportManifestLibrary tests for folder retrieval

    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    14cec3e View commit details
    Browse the repository at this point in the history

  5. Moved transportManifest tests into the Audit unit tests project. Shou… 

    …ld these live in a shared ServiceControl.UnitTests project which doesn't exist currently?
    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    fd25beb View commit details
    Browse the repository at this point in the history

  6. Added typeload tests for transport and manifest persistence to guard … 

    …against spelling errors
    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    9f2e794 View commit details
    Browse the repository at this point in the history

  7. Added test back in

    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c15bfb0 View commit details
    Browse the repository at this point in the history

  8. Make sure audit port and maintenance port don't match

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    92b9cd6 View commit details
    Browse the repository at this point in the history

  9. Moved transport manifest tests from Audit to Transport.Tests

    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    812e83f View commit details
    Browse the repository at this point in the history

  10. Merge branch 'F5-experience' of https://github.com/Particular/Service… 

    …Control into F5-experience
    @jpalac
    jpalac committed May 23, 2023
    Configuration menu
    Copy the full SHA
    15a655d View commit details
    Browse the repository at this point in the history

  11. Add optional database settings

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8e013fc View commit details
    Browse the repository at this point in the history

  12. Separate the audit db from the primary instance

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2569104 View commit details
    Browse the repository at this point in the history

  13. Test that transports can be loaded from root (production env layout)

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    96e0cfb View commit details
    Browse the repository at this point in the history

  14. Add missing TestFixture attribute

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e54c03c View commit details
    Browse the repository at this point in the history

  15. Remove

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e4d2c8e View commit details
    Browse the repository at this point in the history

  16. Add missing TestFixture attribute

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a66f9c8 View commit details
    Browse the repository at this point in the history

  17. Instructions about how to run/debug locally

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    6b02ce1 View commit details
    Browse the repository at this point in the history

  18. Fix approved API

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4f45829 View commit details
    Browse the repository at this point in the history

  19. Re-org persistence manifest tests to follow the same structure as the… 

    … transport manifests tests
    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d7ef6aa View commit details
    Browse the repository at this point in the history

  20. Remove not needed test

    @mauroservienti
    mauroservienti committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d054639 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Added persistence test for loading from root

    @jpalac
    jpalac committed May 24, 2023
    Configuration menu
    Copy the full SHA
    db995b9 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3531 from Particular/reorg-peristence-manifest-tests 

    Re-org persistence manifest tests to follow the same structure as the transport manifests tests
    @jpalac
    jpalac committed May 24, 2023
    Configuration menu
    Copy the full SHA
    2178304 View commit details
    Browse the repository at this point in the history

  3. added logging

    @jpalac
    jpalac committed May 24, 2023
    Configuration menu
    Copy the full SHA
    32a34ab View commit details
    Browse the repository at this point in the history

  4. added persistence type to config log

    @jpalac
    jpalac committed May 24, 2023
    Configuration menu
    Copy the full SHA
    ff507bb View commit details
    Browse the repository at this point in the history

  5. Added persistence customization type name to logs

    @jpalac
    jpalac committed May 24, 2023
    Configuration menu
    Copy the full SHA
    a2b02e7 View commit details
    Browse the repository at this point in the history

  6. Fix build order 

    The test projects had two reference to the in-memory persistence and learning transport and the behavior was non-deterministic
    @mikeminutillo
    mikeminutillo committed May 24, 2023
    Configuration menu
    Copy the full SHA
    38daca8 View commit details
    Browse the repository at this point in the history

  7. Cleanup for code review 

    Co-Authored-By: Jo Palac <jpalac@users.noreply.github.com>
    @mikeminutillo @jpalac
    mikeminutillo and jpalac committed May 24, 2023
    Configuration menu
    Copy the full SHA
    32d36d9 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #3532 from Particular/F5-experience-docs

    @mauroservienti
    mauroservienti committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b7d7124 View commit details
    Browse the repository at this point in the history