Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licensing cleanup #4253

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Licensing cleanup #4253

merged 3 commits into from
Jun 25, 2024

Conversation

bording
Copy link
Member

@bording bording commented Jun 21, 2024

This PR cleans up how ServiceControl handles licenses in the following ways:

  • Setup commands no longer validate license files or attempt to copy license information to disk. It is assumed that when an instance starts, a valid license is has been provided in the standard locations. This is already true for the current deployment methods (SCMU and PowerShell) and a license will need to be provided for containers.
  • The LicenseManager code that was used solely for the Setup commands has now been removed.
  • There was custom code that duplicating the existing license validation code, so that has been changed to replace the custom code with the standard validation path.

@DavidBoike DavidBoike merged commit f3a8c06 into master Jun 25, 2024
23 checks passed
@DavidBoike DavidBoike deleted the licensing-cleanup branch June 25, 2024 14:42
@DavidBoike DavidBoike mentioned this pull request Jun 26, 2024
Closed
@bording bording mentioned this pull request Jun 27, 2024
Merged
bording added a commit that referenced this pull request Jun 27, 2024
@bording
Licensing cleanup (#4253)
080558e 
* Stop trying to validate and import license from Setup command

* Clean up LicenseManager after removing code from Setup commands

* Use standard license validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBoike DavidBoike DavidBoike approved these changes

@boblangley boblangley Awaiting requested review from boblangley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bording @DavidBoike