Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceInsight does not provide the reason to why a license is invalid #502

Closed
ramonsmits opened this issue Sep 23, 2015 · 36 comments
Closed
Assignees
Milestone

Comments

@ramonsmits
Copy link
Member

ramonsmits commented Sep 23, 2015

The license error message should contain information about which condition has not been met to help the customer in identifying the license issue. The error messages should be displayed in ServiceInsight when importing the license.

@colin-higgins
Copy link

@ramonsmits @Particular/serviceinsight
Another customer with this problem on v1.4.1

@colin-higgins
Copy link

@Particular/insight-maintainers I would argue that this should be classified as a bug. If the UpgradeProtectionExpired date is bad, the user never has a chance to import a new license as the application quits immediately.

I would think they should have the option to import a new license.

@boblangley
Copy link
Member

@boblangley
Copy link
Member

This is marked as a feature, but appears to be a bug. The problem seems to be that once an expired / invalid license is imported the user does not have a friendly way to correct it once a valid license is obtained. Can we change the title and description?

@distantcam
Copy link
Contributor

Yes I think this is worth escalating to a bug. The reason why it was labeled a feature was because features are anything that are not bugs.

@HEskandari HEskandari added Bug and removed Feature labels Feb 28, 2016
@HEskandari
Copy link
Contributor

Here's a summary of what we discussed:

  • When evaluating license expiry, there are two values at play: Expired Date and Upgrade Protection. This is due to how SI is marketed and sold (enterprise license vs. perpetual)
  • Customers on perpetual license can upgrade to the versions released prior to Upgrade Protection expiry date. Currently, if they upgrade beyond that date, the application will not launch. They message they get is license expired. They wouldn't know they have to downgrade and which version to downgrade to.
  • The version to date mapping can be inferred from the Github Release page, if a link / guidance is provided.

There is a Platform Dev issue open for aligning the licensing behaviors across the products but the maintainers group is looking for a fix as an interim solution, with an eye on future requirements.

@Particular/serviceinsight-maintainers would like to follow a similar approach to NServiceBus core where it doesn't shutdown when the valid license can not be found. To achieve this in the context of a desktop application, we have decided to change ServiceInsight to a "nagware" with potential of limiting the functionalities in future. Basically, if a trial is expired, proper license can not be found or upgrade protection has expired, we display a nag screen. The information in the nag screen can guide the user to take an action, e.g. in case of Upgrade Protection expiration, we can provide guidance to the user to downgrade to the latest allowed release. This would allow users to:

  • Keep running SI in case of emergencies until they upgrade.
  • Have a clear path to downgrade, in case of accidental upgrades (auto updates, PI updates, manual updates).
  • Allow them to try a new release/patch that they wouldn't be able to otherwise, before they decide if they should upgrade.

Please provide your comments here.

@gbiellem
Copy link
Contributor

gbiellem commented Mar 2, 2016

👍 Seems sensible

@boblangley
Copy link
Member

So are we only showing the nagware screen until they downgrade?

@gbiellem
Copy link
Contributor

gbiellem commented Mar 2, 2016

@boblangley I think what you getting at is that there should be some indication in the old copy of SI that the maintenance has expired. Correct?

@boblangley
Copy link
Member

As I understand it, now the software has the potential to just not work at all. The proposal is to allow the software to launch, but show a nagware license window. With this proposed solution can they just click past it and continue using SI?

@johnsimons
Copy link
Member

@boblangley yes that is exactly the proposal

@johnsimons
Copy link
Member

@HEskandari I think is worth expanding on how exactly you propose to handle the case of Upgrade Protection expiration

@HEskandari
Copy link
Contributor

@boblangley If I understand correctly, yes they can continue using the unlicensed software if they choose to, similar to how they can ignore license warnings when it is expired in NServiceBus.

@johnsimons
Copy link
Member

IMHO, as a user I would like to be told at install time that my Upgrade Protection has expired, so I don't have to go through the pain of upgrading to then downgrade it

@gbiellem
Copy link
Contributor

gbiellem commented Mar 2, 2016

@johnsimons IMO the product should also indicate that the maintenance or license has lapsed, not just the installer.

@johnsimons
Copy link
Member

IMO the product should also indicate that the maintenance or license has lapsed, not just the installer.

Yes and it should warn the users even before it expires

@HEskandari
Copy link
Contributor

@johnsimons that's what we need to do in Platform Installer and more around the process of upgrading the products. The purpose of this is how to deal with the situation where you are somehow updated your version past the allowed version.

What I propose is:

  • If license is expired (trial or otherwise), show a nag screen with a link to renew the license.
  • If upgrade protection is expired, show a nag screen with a different message and a link to take them to Github Releases page. They'll need to lookup at their license, check the upgrade protection expiration date and do the math to see which version was the last version they're allowed to run.

@HEskandari
Copy link
Contributor

Yes and it should warn the users even before it expires

👍 I like that.

@gbiellem
Copy link
Contributor

gbiellem commented Mar 2, 2016

Any out of maintenance warning should be less intrusive than an out of license nag screen.
It's not a error condition it just limits your ability to upgrade.

@boblangley
Copy link
Member

Any out of maintenance warning should be less intrusive than an out of license nag screen.

👍 I would suggest we even split that part out as a separate enhancement feature so it can be prioritized separately.

-If license is expired (trial or otherwise), show a nag screen with a link to renew the license.
-If upgrade protection is expired and they have installed an invalid version, show a nag screen with a different message and a link to take them to Github Releases page. They'll need to lookup at their license, check the upgrade protection expiration date and do the math to see which version was the last version they're allowed to run.

👍 for the nag screen as @HEskandari proposed. As an additional split out feature enhancement could we can figure this out how for them?

@willie-levy-zz
Copy link

Just as a question, what would be involved in somehow not allowing the upgrade in the first place if the client isn't entitled to it? this way preventing clients with a lapsed Upgrade protection (but a perpetual license) getting the license expired screen?

@boblangley
Copy link
Member

Just as a question, what would be involved in somehow not allowing the upgrade in the first place if the client isn't entitled to it? this way preventing clients with a lapsed Upgrade protection (but a perpetual license) getting the license expired screen?

I think we agree that should be done as well (as proposed by @HEskandari and @johnsimons), but should be done as another issue so it can be scoped separately.

@boblangley boblangley changed the title License error message can be improved ServiceInsight provides no user friendly way to resolve upgrade protection license issues when an invalid version is installed. Mar 2, 2016
@HEskandari
Copy link
Contributor

@boblangley 👍 on separating the enhancements to a separate feature request. I'll create one for that.

@KimberlyRichardson
Copy link

@HEskandari

If upgrade protection is expired, show a nag screen with a different message and a link to take them to Github Releases page. They'll need to lookup at their license, check the upgrade protection expiration date and do the math to see which version was the last version they're allowed to run.

Is there a way to give them a specific message instead of having them check that their UP is valid? A lot of times, the person who writes in saying that they are receiving the error messages has no idea that the UP has expired (just had this case over the weekend) as they weren't involved in the purchasing or renewal. Could the popup say "Your upgrade protection has expired, please contact your licensing administrator (or whatever the role is of the person who has purchased the license on their end) or something like that? This would allow for more communication within their team.

@HEskandari
Copy link
Contributor

@kimberlya Sure, we can use a wording that works best communication wise.

This aside, do you think it helps if we show the license expiration / UP expiration in the About / License Window of the ServiceInsight? As you say, they won't notice because we don't show the expiration anywhere and it may be stored in Windows Registry making it non-obvious.

@KimberlyRichardson
Copy link

@HEskandari i think thats a great idea. it's not a secret so i don't see any reason why we wouldn't want to show it and this way they know exactly what the reason is that it's not working.

@HEskandari
Copy link
Contributor

After discussion with @Particular/serviceinsight-maintainers we decided that only the nagware related work should be focus of this issue and the other enhancements should be part of #569.

@HEskandari
Copy link
Contributor

HEskandari commented Apr 18, 2017

@Particular/serviceinsight-maintainers If we don't close the app after a valid license can not be found, we're already displaying the registration dialog. Isn't that enough to act as a nag screen? Do we need a specific dialog for the nag screen? I think that would be too much.

If we decide to go with the registration dialog, we need to decide the following:

  • Which buttons should be visible (currently we have these buttons: Contact Sales, Purchase, Browse...)

  • What should be the displayed text? The text should be generic enough to cover a Trail license expired, a commercial license expired or upgrade protection expired and no license found at all. Currently, the text is: "Please click 'Contact Sales' to request an extension to your free trial, or click 'Buy Now' to purchase a license online. When you receive your license file, save it to disk and then click the 'Browse' button to select it."

  • What should be the title of the dialog? (Currently: ServiceInsight - License Expired)

@DavidBoike
Copy link
Member

Is this still in progress? Had a customer via live chat with this problem again today.

@adamralph
Copy link
Member

@DavidBoike AFAIK we're not actively working on it right now, but it sounds like we perhaps should be. @Particular/serviceinsight-maintainers thoughts?

@WilliamBZA
Copy link
Member

@ramonsmits The "Browse" button for importing licenses is always visible now - regardless of the license installed, so I think that this issue is no longer applicable as the user can install new licenses whenever the dialog pops up.

The upgrade protection expiration date is also currently only compared to the release date of the current application. So if the normal Expiration date is in the future (i.e. the license is still valid) they will be shown the expired license dialog if they are using a version of ServiceInsight that is released after their upgrade protection has expired - even if their actual license expiration is set to be in the future. In this scenario they are trying to use a version of ServiceInsight they are not licensed for.

Happy for us to close this?

/cc @DavidBoike

@ramonsmits
Copy link
Member Author

In this scenario they are trying to use a version of ServiceInsight they are not licensed for.

@WilliamBZA The issue is not that they have an incorrect license, the issue is that the user is not informed the reason why the license isn't valid.

If you say that now the feedback about the invalid license is addressed so that the user knows how to resolve their license issue then this issue can be closed.

@WilliamBZA
Copy link
Member

The feedback given to the user has not changed, but they now have the option to import a new license when the dialog shows.

I guess that means this stays open.

@ramonsmits
Copy link
Member Author

@WilliamBZA I think we should show the reason for license expiration. Not only that it is expired without details. If the maintainers think so too then please leave it open. If not, then please state the reason for withdrawing and close.

@timbussmann
Copy link
Contributor

A customer had this issue recently as well. Selecting an outdated license via the browse button seems like it does nothing when the license in no longer valid (the upgrade protection date expired) but there is no hint about this problem at all.

@HEskandari HEskandari removed their assignment May 1, 2018
@HEskandari HEskandari added this to the 1.10.3 milestone May 23, 2018
@HEskandari HEskandari changed the title ServiceInsight provides no user friendly way to resolve upgrade protection license issues when an invalid version is installed. ServiceInsight does not provide feedback to the user when a license is validated Jun 7, 2018
@HEskandari
Copy link
Contributor

HEskandari commented Jun 7, 2018

I have raised #803 to resolve this. It now shows all the errors raised during license validation when you import a license via Register menu. I have also updated the title to reflect this.

@HEskandari HEskandari self-assigned this Jun 7, 2018
@HEskandari HEskandari changed the title ServiceInsight does not provide feedback to the user when a license is validated ServiceInsight does not provide the reason to why a license is invalid Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests