-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make msg selection highlight color neutral #743
Comments
@sergioc could you provide some mock ups? |
I could, but it would be faster to visualize this directly in XAML. |
Discussed this with @HEskandari - he will provide screenshots. |
@sergioc Do you have specific colors in mind? |
We can start from #222222 for dark grey (will require text to be white) and #bbbbbb for light grey and tweak from there. |
@HEskandari are these two alternatives? Or are these two possible states? |
These are the two colors suggested by @sergioc. There's not much of a possible state, as there's always one row selected/focused (unless there's no data). |
@adamralph we could have that option, if we choose to, but since the Messages list always has something selected, I think it makes sense to not have active/inactive distinction. |
@HEskandari that two states indicate whether the messages list has focus or not. In both states, there is a message selected. |
Alternatives
I think the grey doesn't completely solve the issue of contrast. Black would work better contrasting with most colors and is easy to see. How would both look in a screenshot showing the whole application? Would black still be jarring? Would you notice that jarriness during normal usage where your task will never be to analyse the color of the highlight?
That actually gives an idea of not putting the highlight background behind the icon. Then we can use whatever color, including a blue used in the different diagrams. Would that be possible? |
@sergioc without analysing it too deeply, I simplify prefer the look of the grey highlight to the black one. It's striking enough to immediately convey that it's the active row, without looking odd, which I think a black highlight does. Is there an example of another UI which uses a black background to indicate the active row in a list?
I'm not sure, but given that the icon is in it's own cell in the row, I think that could look a little weird. |
Not from the top of my mind. |
The black one looks like designing SI for people with vision impairment. Why does it have to be that contrasty? To me, the gray looks better, is contrasty enough to convey the meaning and matches the rest of the theme. |
Black is more noticeable, has no issue contrasting with other colors and there's no confusion with out of focus panes or windows. Can you produce some screenshots of the entire app with the different highlight colors? |
Here are the full app screenshots. Dark gray selected row (#222222): Light gray selected row (#bbbbbb): @sergioc let me know if you want to jump on a call and tweak the colors. |
My vote goes for the light gray |
@sergioc Not highlighting the first column, even if possible has a higher effort (since the grid only has the concept of a selected row out of the box). |
While working on #739, it occurred to me that the current message selection highlight color isn't particularly appealing nor contrasts well with some icons.
Proposal 1
Proposal 2
Proposal 1 will likely give better results, but will require changes to "archive" and "retry requested"
The text was updated successfully, but these errors were encountered: